Bug 109227 - [EFL][Qt][WK2] Dark actual image in webgl-composite-modes-repaint test.
Summary: [EFL][Qt][WK2] Dark actual image in webgl-composite-modes-repaint test.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords:
Depends on:
Blocks: 104459 105029
  Show dependency treegraph
 
Reported: 2013-02-07 13:38 PST by Viatcheslav Ostapenko
Modified: 2017-03-11 10:49 PST (History)
9 users (show)

See Also:


Attachments
webgl-composite-modes-repaint-actual.png (4.53 KB, image/png)
2013-02-07 13:38 PST, Viatcheslav Ostapenko
no flags Details
webgl-composite-modes-repaint-expected.png (4.47 KB, image/png)
2013-02-07 13:40 PST, Viatcheslav Ostapenko
no flags Details
Patch (6.38 KB, patch)
2013-02-24 14:44 PST, Viatcheslav Ostapenko
laszlo.gombos: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2013-02-07 13:38:46 PST
Created attachment 187169 [details]
webgl-composite-modes-repaint-actual.png

Check attached expected and actual images.
Comment 1 Viatcheslav Ostapenko 2013-02-07 13:40:52 PST
Created attachment 187170 [details]
webgl-composite-modes-repaint-expected.png
Comment 2 Viatcheslav Ostapenko 2013-02-12 00:18:22 PST
It appears that in webgl-composite-modes-repaint test everything works as it implemented.

This test uses fast/repaint/resources/repaint.js to invoke repaintTest after initial paint.
repaint.js forces page re-layout and uses testRunner.display() before invoking testRunner.js . 
testRunner.display() paints page contents shadowed by gray surface, so this test produces darker blue tiles with canvas content composited on top.
The repaintTest() method contains code which only changes canvas content, so only canvases get updated, but not tiles.
From all this it looks that webgl-composite-modes-repaint-actual.png is correct test output.
At the same time on chromium canvas update causes full page repaint and final page snapshot appears brighter.
Comment 3 Noam Rosenthal 2013-02-12 09:49:24 PST
chromium pixel test results don't show the repaint-counter "Grayness".
Comment 4 Viatcheslav Ostapenko 2013-02-12 09:53:43 PST
(In reply to comment #3)
> chromium pixel test results don't show the repaint-counter "Grayness".

Yes, that's what I'm trying to figure out now.
It seems chromium does full screen update instead of canvas update. I need more digging.
Comment 5 James Robinson 2013-02-12 12:06:24 PST
(In reply to comment #4)
> (In reply to comment #3)
> > chromium pixel test results don't show the repaint-counter "Grayness".
> 
> Yes, that's what I'm trying to figure out now.
> It seems chromium does full screen update instead of canvas update. I need more digging.

That's what happens in chromium in compositing mode.
Comment 6 Viatcheslav Ostapenko 2013-02-12 12:33:40 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > chromium pixel test results don't show the repaint-counter "Grayness".
> > 
> > Yes, that's what I'm trying to figure out now.
> > It seems chromium does full screen update instead of canvas update. I need more digging.
> 
> That's what happens in chromium in compositing mode.

Is it by design or is it a known bug?
Comment 7 Noam Rosenthal 2013-02-12 12:48:37 PST
I think we should close this bug as INVALID, even though I agree that the difference between the "bright" Chromium version and the gray Mac/Qt/EFL version is confusing.
Comment 8 Viatcheslav Ostapenko 2013-02-12 13:03:48 PST
(In reply to comment #7)
> I think we should close this bug as INVALID, even though I agree that the difference between the "bright" Chromium version and the gray Mac/Qt/EFL version is confusing.

Should I add port specific snapshots for expected.png?
Comment 9 Kalyan 2013-02-23 06:21:50 PST
(In reply to comment #8)
> (In reply to comment #7)
> 
> Should I add port specific snapshots for expected.png?
I would propose to add them. Even though expected.png has the "Grayness" it would be at least possible to track any regression with canvas content.
Comment 10 Viatcheslav Ostapenko 2013-02-24 14:44:05 PST
Created attachment 189989 [details]
Patch
Comment 11 Laszlo Gombos 2013-02-27 13:49:52 PST
Comment on attachment 189989 [details]
Patch

The image for the expected test result does not seems to be correct. Can you double-check ?
Comment 12 Michael Catanzaro 2017-03-11 10:49:29 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.