Bug 109223 - Improve logging of MediaPlayerPrivateAVFoundation Notifications.
Summary: Improve logging of MediaPlayerPrivateAVFoundation Notifications.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 13:17 PST by Jer Noble
Modified: 2013-02-07 15:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.18 KB, patch)
2013-02-07 13:24 PST, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-02-07 13:17:19 PST
Improve logging of MediaPlayerPrivateAVFoundation Notifications.
Comment 1 Jer Noble 2013-02-07 13:24:12 PST
Created attachment 187163 [details]
Patch
Comment 2 Eric Carlson 2013-02-07 13:28:42 PST
Comment on attachment 187163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187163&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:699
> +static const char* stringifyNotificationType(MediaPlayerPrivateAVFoundation::Notification::Type type)

Nit: this name is odd, maybe just notificationName?
Comment 3 Jer Noble 2013-02-07 15:20:48 PST
Committed r142186: <http://trac.webkit.org/changeset/142186>