Bug 109221 - build-webkit: document sdk, debug, release, device, and simulator options
Summary: build-webkit: document sdk, debug, release, device, and simulator options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P3 Minor
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 13:07 PST by David Farler
Modified: 2013-02-09 11:10 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2013-02-07 13:12 PST, David Farler 		ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2013-02-08 15:52 PST, David Farler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2013-02-07 13:07:34 PST 
Add comments in build-webkit usage for the following command line switches:

—sdk=<sdk>
—debug
—release
—device
—simulator

We should remove switches for —devel and —deploy when determining the Xcode configuration while we are at it.
Comment 1 David Farler 2013-02-07 13:12:39 PST 
Created attachment 187159 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2013-02-07 20:05:05 PST 
Comment on attachment 187159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187159&action=review

r=me with those changes.

> Tools/Scripts/build-webkit:112
> -  --debug                           Compile in debug mode
> +  --debug                           Compile with Debug Xcode configuration
> +  --release                         Compile with Release Xcode configuration

The --debug (and --release) switches are used by more than just platforms that build with Xcode.

I would suggest removing "Xcode" from the help text here.

> Tools/Scripts/build-webkit:113
> +  --sdk=<sdk>                       Use a specific Xcode SDK

I would add "(iOS and Mac only)" to the end of the description here.

> Tools/Scripts/build-webkit:115
> +  --device                          Use the iphoneos.internal SDK
> +  --simulator                       Use the iphonesimulator SDK

Similarly, add "(iOS only)" here.  Maybe:

Use the current <sdkname> SDK (iOS only)
Comment 3 David Farler 2013-02-08 15:52:33 PST 
Created attachment 187377 [details]
Patch

Patch updated with the above suggestions.
Comment 4 David Kilzer (:ddkilzer) 2013-02-08 21:06:51 PST 
Comment on attachment 187377 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2013-02-09 11:10:40 PST 
Comment on attachment 187377 [details]
Patch

Clearing flags on attachment: 187377

Committed r142373: <http://trac.webkit.org/changeset/142373>
Comment 6 WebKit Review Bot 2013-02-09 11:10:44 PST 
All reviewed patches have been landed.  Closing bug.