A lot of defines are set in the command-line via automake. This means that the command-line is very long and that other build systems using autoconf cannot share the defines.
Created attachment 187139 [details]
Comment on attachment 187139 [details]
I assume there's really no reason to define some things to 1 and others to nothing (ie, just define th esymbol), so I'd rather make it consistent while we are at it. Other than that it makes sense to me.
Created attachment 187158 [details]
Comment on attachment 187158 [details]
Rejecting attachment 187158 [details] from commit-queue.
Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 187158, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue
/mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Full output: http://queues.webkit.org/results/16426341
Created attachment 187161 [details]
Committed r142179: <http://trac.webkit.org/changeset/142179>