Bug 109203 – [Mac] respect in-band caption color

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

In-band captions can specify foreground (text) and background color.

[Radar WebKit Bug Importer]

<rdar://problem/13171845>

[Eric Carlson]

Created attachment 187404 [details]
Proposed patch

[WebKit Review Bot]

Attachment 187404 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/track/track-in-band-style-expected.txt', u'LayoutTests/media/track/track-in-band-style.html', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/html/track/InbandTextTrack.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackCueGeneric.cpp', u'Source/WebCore/html/track/TextTrackCueGeneric.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp']" exit_code: 1
Source/WebCore/html/track/TextTrackCue.h:144:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 187406 [details]
Updated patch

[Dean Jackson]

Comment on attachment 187406 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187406&action=review

> Source/WebCore/ChangeLog:10
> +        * WebCore.xcodeproj/project.pbxproj:

Probably should mention you exported HTMLDivElement. Actually, why do you do this?

> LayoutTests/media/track/track-in-band-style-expected.txt:14
> +EXPECTED (getComputedStyle(cueDisplayElement).color == 'rgb(255, 255, 255)') OK
> +EXPECTED (getComputedStyle(cueNode).backgroundColor == 'rgb(0, 0, 0)') OK

Are these actually set in counting-captioned.mov? I'm wondering what the default values would be, and whether this test would pass on any captioned movie that doesn't set the style.

[Eric Carlson]

Committed http://trac.webkit.org/r142349