Bug 109203 - [Mac] respect in-band caption color
Summary: [Mac] respect in-band caption color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-07 09:14 PST by Eric Carlson
Modified: 2013-02-08 21:57 PST (History)
7 users (show)

See Also:

Attachments
Proposed patch (23.36 KB, patch)
2013-02-08 20:56 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (23.36 KB, patch)
2013-02-08 21:16 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-07 09:14:17 PST 
In-band captions can specify foreground (text) and background color.
Comment 1 Radar WebKit Bug Importer 2013-02-07 09:14:36 PST 
<rdar://problem/13171845>
Comment 2 Eric Carlson 2013-02-08 20:56:25 PST 
Created attachment 187404 [details]
Proposed patch
Comment 3 WebKit Review Bot 2013-02-08 20:58:42 PST 
Attachment 187404 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/track/track-in-band-style-expected.txt', u'LayoutTests/media/track/track-in-band-style.html', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/html/track/InbandTextTrack.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackCueGeneric.cpp', u'Source/WebCore/html/track/TextTrackCueGeneric.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp']" exit_code: 1
Source/WebCore/html/track/TextTrackCue.h:144:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2013-02-08 21:16:30 PST 
Created attachment 187406 [details]
Updated patch
Comment 5 Dean Jackson 2013-02-08 21:27:45 PST 
Comment on attachment 187406 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187406&action=review

> Source/WebCore/ChangeLog:10
> +        * WebCore.xcodeproj/project.pbxproj:

Probably should mention you exported HTMLDivElement. Actually, why do you do this?

> LayoutTests/media/track/track-in-band-style-expected.txt:14
> +EXPECTED (getComputedStyle(cueDisplayElement).color == 'rgb(255, 255, 255)') OK
> +EXPECTED (getComputedStyle(cueNode).backgroundColor == 'rgb(0, 0, 0)') OK

Are these actually set in counting-captioned.mov? I'm wondering what the default values would be, and whether this test would pass on any captioned movie that doesn't set the style.
Comment 6 Eric Carlson 2013-02-08 21:56:55 PST 
Committed http://trac.webkit.org/r142349