Bug 109202 – [BlackBerry] Cookie database isn't loaded into memory in some rare cases

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

If we get into a state where the get/setcookie calls are called before the database is loaded in the first async call, reload the cookie database using a sync call to make sure it's loaded properly.

Created attachment 187126 [details]
Patch

[Yong Li]

Comment on attachment 187126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187126&action=review

> Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:322
> +        if (isCurrentThread())
> +            BlackBerry::Platform::webKitThreadMessageClient()->dispatchSyncMessage(createMethodCallMessage(&CookieManager::getBackingStoreCookies, &cookieManager()));
> +        else
> +            cookieManager().getBackingStoreCookies();

I'm not sure this is right. we send message when it is current thread? maybe we want the opposite?

[Yong Li]

Comment on attachment 187126 [details]
Patch

never mind

[WebKit Review Bot]

Comment on attachment 187126 [details]
Patch

Rejecting attachment 187126 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 187126 [details]
Patch

Clearing flags on attachment: 187126

Committed r142150: <http://trac.webkit.org/changeset/142150>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.