RESOLVED FIXED 109192
Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent 
https://bugs.webkit.org/show_bug.cgi?id=109192
Summary Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on W...
Andrey Kosyakov
Reported 2013-02-07 08:09:20 PST
This removes frame and compositing instrumentation methods from InspectorInstrumentation and exposes them via WebDevToolsAgent. The plan is to remove these methods from WebWidget interface and use methods on WebDevToolsAgent instead.
Attachments
Patch (17.33 KB, patch)
2013-02-07 08:13 PST, Andrey Kosyakov 		pfeldman: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (21.22 KB, patch)
2013-02-08 02:28 PST, Andrey Kosyakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (22.66 KB, patch)
2013-02-08 08:27 PST, Andrey Kosyakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2013-02-07 08:13:28 PST
Created attachment 187114 [details] Patch
WebKit Review Bot
Comment 2 2013-02-07 08:14:46 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Build Bot
Comment 3 2013-02-07 10:01:22 PST
Comment on attachment 187114 [details] Patch Attachment 187114 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16418255
Build Bot
Comment 4 2013-02-07 10:30:57 PST
Comment on attachment 187114 [details] Patch Attachment 187114 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16408384
Build Bot
Comment 5 2013-02-07 16:20:42 PST
Comment on attachment 187114 [details] Patch Attachment 187114 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16418391
Pavel Feldman
Comment 6 2013-02-07 23:52:09 PST
Comment on attachment 187114 [details] Patch Watch out for the wk bot failures
Andrey Kosyakov
Comment 7 2013-02-08 02:28:07 PST
Created attachment 187272 [details] Patch
Build Bot
Comment 8 2013-02-08 02:52:01 PST
Comment on attachment 187272 [details] Patch Attachment 187272 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16434574
Build Bot
Comment 9 2013-02-08 02:54:03 PST
Comment on attachment 187272 [details] Patch Attachment 187272 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16428594
Andrey Kosyakov
Comment 10 2013-02-08 08:27:07 PST
Created attachment 187324 [details] Patch
James Robinson
Comment 11 2013-02-08 19:36:44 PST
Great, this definitely works for me. I'll rebase my patch on top of this after it lands. Thanks!
Build Bot
Comment 12 2013-02-11 15:32:25 PST
Comment on attachment 187324 [details] Patch Attachment 187324 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16501381
James Robinson
Comment 13 2013-02-12 13:52:59 PST
What's the status here? Is there any way I can help?
Build Bot
Comment 14 2013-02-12 15:17:19 PST
Comment on attachment 187272 [details] Patch Attachment 187272 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16513436
Andrey Kosyakov
Comment 15 2013-02-14 08:41:12 PST
Committed r142879: <http://trac.webkit.org/changeset/142879>
Note You need to log in before you can comment on or make changes to this bug.