Bug 109188 – [EFL] Add a WebKit2 Performance bot.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

[EFL] Add a WebKit2 Performance bot.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 187095 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

I've CC'ed Ossy in case he's willing to double-check the config.json changes.

I guess the bot first needs to be active in build.webkit.org, so I'd need to set things up with Lucas before hooking the new machine into appspot.com with Ryosuke, right?

[Lucas Forschler]

I've added the bot password to the webkit build master and sent it to you via email.  After this patch lands, you should be able to connect.

[Csaba Osztrogonác]

Comment on attachment 187095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187095&action=review

LGTM with a typo fix.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:350
> +                      "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTestWebKit2", "builddir": "efl-linux-64-release-wk2-perf",

I assume you meant DownloadAndPerfTestWebKit2 instead of BuildAndPerfTestWebKit2

[Raphael Kubo da Costa (:rakuco)]

Created attachment 187106 [details]
Patch for landing

[Raphael Kubo da Costa (:rakuco)]

Committed r142121: <http://trac.webkit.org/changeset/142121>

[Csaba Osztrogonác]

Comment on attachment 187106 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:440
> +                    { "type": "Triggerable", "name": "efl-linux-64-release-wk2-perf",
> +                      "builderNames": ["EFL Linux 64-bit Release WK2 (Perf)"]

typo: s/efl-linux-64-release-wk2-perf/efl-linux-perf-1

[Csaba Osztrogonác]

Comment on attachment 187106 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:336
> +                      "triggers": ["efl-linux-perf-1"],

I was wrong. The typo is here. It should be: "triggers": ["efl-linux-64-release-wk2-perf"]
Because we don't trigger the builder itself, but the triggerable scheduler which has this name.

[Csaba Osztrogonác]

Fix landed in https://trac.webkit.org/changeset/142133

[Ryosuke Niwa]

See 109342.