Bug 109188 - [EFL] Add a WebKit2 Performance bot.
Summary: [EFL] Add a WebKit2 Performance bot.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks: 109342
  Show dependency treegraph
 
Reported: 2013-02-07 06:50 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2013-02-08 21:08 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2013-02-07 06:51 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch for landing (3.04 KB, patch)
2013-02-07 07:34 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2013-02-07 06:50:27 PST
[EFL] Add a WebKit2 Performance bot.
Comment 1 Raphael Kubo da Costa (:rakuco) 2013-02-07 06:51:42 PST
Created attachment 187095 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2013-02-07 06:53:04 PST
I've CC'ed Ossy in case he's willing to double-check the config.json changes.

I guess the bot first needs to be active in build.webkit.org, so I'd need to set things up with Lucas before hooking the new machine into appspot.com with Ryosuke, right?
Comment 3 Lucas Forschler 2013-02-07 07:00:21 PST
I've added the bot password to the webkit build master and sent it to you via email.  After this patch lands, you should be able to connect.
Comment 4 Csaba Osztrogonác 2013-02-07 07:23:50 PST
Comment on attachment 187095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187095&action=review

LGTM with a typo fix.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:350
> +                      "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTestWebKit2", "builddir": "efl-linux-64-release-wk2-perf",

I assume you meant DownloadAndPerfTestWebKit2 instead of BuildAndPerfTestWebKit2
Comment 5 Raphael Kubo da Costa (:rakuco) 2013-02-07 07:34:40 PST
Created attachment 187106 [details]
Patch for landing
Comment 6 Raphael Kubo da Costa (:rakuco) 2013-02-07 07:37:14 PST
Committed r142121: <http://trac.webkit.org/changeset/142121>
Comment 7 Csaba Osztrogonác 2013-02-07 08:31:12 PST
Comment on attachment 187106 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:440
> +                    { "type": "Triggerable", "name": "efl-linux-64-release-wk2-perf",
> +                      "builderNames": ["EFL Linux 64-bit Release WK2 (Perf)"]

typo: s/efl-linux-64-release-wk2-perf/efl-linux-perf-1
Comment 8 Csaba Osztrogonác 2013-02-07 08:34:08 PST
Comment on attachment 187106 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:336
> +                      "triggers": ["efl-linux-perf-1"],

I was wrong. The typo is here. It should be: "triggers": ["efl-linux-64-release-wk2-perf"]
Because we don't trigger the builder itself, but the triggerable scheduler which has this name.
Comment 9 Csaba Osztrogonác 2013-02-07 08:51:06 PST
Fix landed in https://trac.webkit.org/changeset/142133
Comment 10 Ryosuke Niwa 2013-02-08 21:08:32 PST
See 109342.