Bug 109186 – [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h.

[Kentaro Hara]

Created attachment 187085 [details]
Patch

[Adam Barth]

Comment on attachment 187085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review

> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);

The "V8HiddenPropertyName::" probably isn't needed any more.

[Kentaro Hara]

Created attachment 187202 [details]
patch for landing

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 187085 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review
> 
> > Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> > +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
> 
> The "V8HiddenPropertyName::" probably isn't needed any more.

Yeah, given that hiddenReferenceName() is called from V8HiddenPropertyName.cpp only, I made the method static.

[Kentaro Hara]

Created attachment 187203 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 187203 [details]
patch for landing

Clearing flags on attachment: 187203

Committed r142217: <http://trac.webkit.org/changeset/142217>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.