Bug 109186 - [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
Summary: [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 06:11 PST by Kentaro Hara
Modified: 2013-02-07 18:12 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.44 KB, patch)
2013-02-07 06:13 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (9.79 KB, patch)
2013-02-07 17:12 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (9.85 KB, patch)
2013-02-07 17:19 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-07 06:11:03 PST 
Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h.
Comment 1 Kentaro Hara 2013-02-07 06:13:16 PST 
Created attachment 187085 [details]
Patch
Comment 2 Adam Barth 2013-02-07 11:09:58 PST 
Comment on attachment 187085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review

> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);

The "V8HiddenPropertyName::" probably isn't needed any more.
Comment 3 Kentaro Hara 2013-02-07 17:12:54 PST 
Created attachment 187202 [details]
patch for landing
Comment 4 Kentaro Hara 2013-02-07 17:14:06 PST 
(In reply to comment #2)
> (From update of attachment 187085 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review
> 
> > Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> > +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
> 
> The "V8HiddenPropertyName::" probably isn't needed any more.

Yeah, given that hiddenReferenceName() is called from V8HiddenPropertyName.cpp only, I made the method static.
Comment 5 Kentaro Hara 2013-02-07 17:19:33 PST 
Created attachment 187203 [details]
patch for landing
Comment 6 WebKit Review Bot 2013-02-07 18:12:39 PST 
Comment on attachment 187203 [details]
patch for landing

Clearing flags on attachment: 187203

Committed r142217: <http://trac.webkit.org/changeset/142217>
Comment 7 WebKit Review Bot 2013-02-07 18:12:43 PST 
All reviewed patches have been landed.  Closing bug.