Bug 109183 - Web Inspector: [Regression] breakpoint condition not editable
Summary: Web Inspector: [Regression] breakpoint condition not editable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 06:01 PST by Andrey Lushnikov
Modified: 2013-02-07 09:19 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2013-02-07 06:31 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (1.95 KB, patch)
2013-02-07 06:55 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (3.13 KB, patch)
2013-02-07 07:17 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-07 06:01:44 PST 
It's impossible to set up a selection inside breakpoint condition editbox.
Comment 1 Andrey Lushnikov 2013-02-07 06:31:56 PST 
Created attachment 187089 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-02-07 06:50:07 PST 
Comment on attachment 187089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187089&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2096
> +        for(var i = 0; i < this._decorationElements; ++i) {

Traversing all decorations element seems not quite efficient.
You can tyr using the fact that all decorations are stored in the div with "webkit-line-decorations" class.
Comment 3 Andrey Lushnikov 2013-02-07 06:55:36 PST 
Created attachment 187097 [details]
Patch
Comment 4 Andrey Lushnikov 2013-02-07 07:17:45 PST 
Created attachment 187103 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-07 09:19:02 PST 
Comment on attachment 187103 [details]
Patch

Clearing flags on attachment: 187103

Committed r142138: <http://trac.webkit.org/changeset/142138>
Comment 6 WebKit Review Bot 2013-02-07 09:19:06 PST 
All reviewed patches have been landed.  Closing bug.