Bug 109172 - Implement drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color) in GraphicsContextSkia
Summary: Implement drawFocusRing(const Vector<IntRect>& rects, int width, int offset, ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 03:49 PST by Changhun Kang
Modified: 2013-04-09 09:39 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2013-02-07 03:58 PST, Changhun Kang 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2013-02-07 22:52 PST, Changhun Kang 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Changhun Kang 2013-02-07 03:49:26 PST 
Implement void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color).
Comment 1 Changhun Kang 2013-02-07 03:58:46 PST 
Created attachment 187049 [details]
Patch

This is a WIP patch.

I refer to the implementation of Qt.

Give me any advice.

Thanks
Comment 2 WebKit Review Bot 2013-02-07 05:33:09 PST 
Comment on attachment 187049 [details]
Patch

Attachment 187049 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16415245
Comment 3 Peter Beverloo (cr-android ews) 2013-02-07 05:34:34 PST 
Comment on attachment 187049 [details]
Patch

Attachment 187049 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16429130
Comment 4 WebKit Review Bot 2013-02-07 09:46:34 PST 
Comment on attachment 187049 [details]
Patch

Attachment 187049 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16429218
Comment 5 Changhun Kang 2013-02-07 22:52:38 PST 
Created attachment 187240 [details]
Patch

Build Fix.
Comment 6 WebKit Review Bot 2013-02-07 23:20:52 PST 
Comment on attachment 187240 [details]
Patch

Attachment 187240 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16426535
Comment 7 WebKit Review Bot 2013-02-07 23:22:14 PST 
Comment on attachment 187240 [details]
Patch

Attachment 187240 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16415625
Comment 8 Peter Beverloo (cr-android ews) 2013-02-07 23:38:05 PST 
Comment on attachment 187240 [details]
Patch

Attachment 187240 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16435500
Comment 9 Darin Adler 2013-04-09 09:39:04 PDT 
Comment on attachment 187240 [details]
Patch

Clearing flags on Skia-specific patch.