Bug 109158 – REGRESSION (r140778):Calendar Picker buttons are wrong when rtl

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

The triangles are pointing the wrong direction.

[Keishi Hattori]

Created attachment 187738 [details]
Patch

[Kent Tamura]

Comment on attachment 187738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187738&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.css:150
> +.rtl .year-month-button-right .year-month-button,
>  .year-month-button-left .year-month-button {
> -    margin-right: 4px;
> +    margin: 0 4px 0 0;
>  }
>  
> -.year-month-button-right {
> -    display: inline-block;
> +.rtl .year-month-button-left .year-month-button,
> +.year-month-button-right .year-month-button {
> +    margin: 0 0 0 4px;

Does -webkit-margin-end: 4px;  work?

> Source/WebCore/Resources/pagepopups/calendarPicker.css:281
>  .today-clear-area .today-button {
> -    margin-right: 8px;
> +    margin: 0 8px 0 0;
> +}
> +
> +.rtl .today-clear-area .today-button {
> +    margin: 0 0 0 8px;

Ditto.

[Keishi Hattori]

Created attachment 187749 [details]
Patch

[Kent Tamura]

Comment on attachment 187749 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 187749 [details]
Patch

Clearing flags on attachment: 187749

Committed r142572: <http://trac.webkit.org/changeset/142572>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.