Bug 109154 - Web Inspector: home button behaviour is wrong in DTE
Summary: Web Inspector: home button behaviour is wrong in DTE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
: 109150 (view as bug list)
Depends on:
Blocks: 109416
  Show dependency treegraph
 
Reported: 2013-02-07 01:22 PST by Andrey Lushnikov
Modified: 2013-02-18 01:30 PST (History)
14 users (show)

See Also:


Attachments
Patch (2.66 KB, patch)
2013-02-07 01:25 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.75 KB, patch)
2013-02-07 02:46 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.74 KB, patch)
2013-02-07 07:19 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (12.11 KB, patch)
2013-02-08 02:10 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (12.79 KB, patch)
2013-02-08 06:02 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-07 01:22:17 PST
Home key button should trigger between first non-blank character of the line and first character of the line.
Comment 1 Andrey Lushnikov 2013-02-07 01:25:33 PST
Created attachment 187022 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-02-07 01:47:30 PST
Comment on attachment 187022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187022&action=review

We should test this.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1411
> +        var firstNonblankCharacter = 0;

NonBlank
Comment 3 Andrey Lushnikov 2013-02-07 02:46:17 PST
Created attachment 187032 [details]
Patch
Comment 4 Andrey Lushnikov 2013-02-07 02:48:02 PST
*** Bug 109150 has been marked as a duplicate of this bug. ***
Comment 5 Vsevolod Vlasov 2013-02-07 04:32:56 PST
Comment on attachment 187032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187032&action=review

> LayoutTests/platform/mac/TestExpectations:257
> +inspector/editor/text-editor-home-button.html [ Skip ]

Skip is actually not neccesary here.
Comment 6 WebKit Review Bot 2013-02-07 07:01:45 PST
Comment on attachment 187032 [details]
Patch

Rejecting attachment 187032 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 187032, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
WebKit/chromium/v8 --revision 13610 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
33>At revision 13610.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 3 files

Full output: http://queues.webkit.org/results/16428199
Comment 7 Andrey Lushnikov 2013-02-07 07:19:51 PST
Created attachment 187104 [details]
Patch
Comment 8 WebKit Review Bot 2013-02-07 09:48:18 PST
Comment on attachment 187104 [details]
Patch

Clearing flags on attachment: 187104

Committed r142142: <http://trac.webkit.org/changeset/142142>
Comment 9 WebKit Review Bot 2013-02-07 09:48:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Gavin Peters 2013-02-07 13:12:30 PST
Reverted r142142 for reason:

Mac expectations were not right.

Committed r142167: <http://trac.webkit.org/changeset/142167>
Comment 12 Vsevolod Vlasov 2013-02-07 20:57:43 PST
Correct flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html



Actual result:
This test verifies that home button triggers selection between first symbol of the line and first non-blank symbol of the line.

function foo()
{
    return 42;
}

Running: testFirstNonBlankCharacter
{"startLine":2,"startColumn":8,"endLine":2,"endColumn":8}
{"startLine":2,"startColumn":4,"endLine":2,"endColumn":4}

Running: testFirstNonBlankCharacterFromWhitespace
{"startLine":2,"startColumn":2,"endLine":2,"endColumn":2}
{"startLine":2,"startColumn":4,"endLine":2,"endColumn":4}

Running: testHomeButtonTriggering
{"startLine":2,"startColumn":2,"endLine":2,"endColumn":2}
{"startLine":2,"startColumn":4,"endLine":2,"endColumn":4}
{"startLine":2,"startColumn":0,"endLine":2,"endColumn":0}
{"startLine":2,"startColumn":4,"endLine":2,"endColumn":4}

Running: testHomeButtonDoesNotChangeCursor
{"startLine":0,"startColumn":2,"endLine":0,"endColumn":2}
{"startLine":0,"startColumn":0,"endLine":0,"endColumn":0}
{"startLine":0,"startColumn":0,"endLine":0,"endColumn":0}

Running: testHomeButtonWithShift
{"startLine":0,"startColumn":0,"endLine":2,"endColumn":8}
{"startLine":0,"startColumn":0,"endLine":2,"endColumn":4}
{"startLine":0,"startColumn":0,"endLine":2,"endColumn":4}
{"startLine":0,"startColumn":0,"endLine":2,"endColumn":4}

Running: testHomeButtonWithShiftInversed
{"startLine":3,"startColumn":1,"endLine":2,"endColumn":8}
{"startLine":3,"startColumn":1,"endLine":2,"endColumn":4}
{"startLine":3,"startColumn":1,"endLine":2,"endColumn":0}
{"startLine":3,"startColumn":1,"endLine":2,"endColumn":4}




Diff:
< {"startLine":0,"startColumn":0,"endLine":2,"endColumn":0}
---
> {"startLine":0,"startColumn":0,"endLine":2,"endColumn":4}
Comment 13 Andrey Lushnikov 2013-02-08 02:10:42 PST
Created attachment 187271 [details]
Patch
Comment 14 Vsevolod Vlasov 2013-02-08 04:54:55 PST
Comment on attachment 187271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187271&action=review

> LayoutTests/inspector/editor/text-editor-home-button-expected.txt:28
> +Running: testHomeButtonTriggering

Toggling
Comment 15 Andrey Lushnikov 2013-02-08 06:02:39 PST
Created attachment 187301 [details]
Patch
Comment 16 WebKit Review Bot 2013-02-11 01:35:54 PST
Comment on attachment 187301 [details]
Patch

Clearing flags on attachment: 187301

Committed r142439: <http://trac.webkit.org/changeset/142439>
Comment 17 WebKit Review Bot 2013-02-11 01:36:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 Kentaro Hara 2013-02-11 03:49:31 PST
inspector/editor/text-editor-home-button.html is failing on Mac. I'll mark the test as [Failure], so please take a look.

https://bugs.webkit.org/show_bug.cgi?id=109416
Comment 19 Stephen Chenney 2013-02-11 08:38:46 PST
The test is failing on all Chromium Mac platforms.
Comment 20 Andrey Lushnikov 2013-02-18 00:29:39 PST

*** This bug has been marked as a duplicate of bug 109416 ***
Comment 21 Vsevolod Vlasov 2013-02-18 01:30:26 PST
It is not correct to mark this bug as a duplicate of that one.
This one is about fixing home button behavior and it is resolved fixed now.
That one is about failing test.