Home key button should trigger between first non-blank character of the line and first character of the line.
Created attachment 187022 [details] Patch
Comment on attachment 187022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187022&action=review We should test this. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1411 > + var firstNonblankCharacter = 0; NonBlank
Created attachment 187032 [details] Patch
*** Bug 109150 has been marked as a duplicate of this bug. ***
Comment on attachment 187032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187032&action=review > LayoutTests/platform/mac/TestExpectations:257 > +inspector/editor/text-editor-home-button.html [ Skip ] Skip is actually not neccesary here.
Comment on attachment 187032 [details] Patch Rejecting attachment 187032 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 187032, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: WebKit/chromium/v8 --revision 13610 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 33>At revision 13610. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 3 files Full output: http://queues.webkit.org/results/16428199
Created attachment 187104 [details] Patch
Comment on attachment 187104 [details] Patch Clearing flags on attachment: 187104 Committed r142142: <http://trac.webkit.org/changeset/142142>
All reviewed patches have been landed. Closing bug.
Reverted r142142 for reason: Mac expectations were not right. Committed r142167: <http://trac.webkit.org/changeset/142167>
See See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
Correct flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html Actual result: This test verifies that home button triggers selection between first symbol of the line and first non-blank symbol of the line. function foo() { return 42; } Running: testFirstNonBlankCharacter {"startLine":2,"startColumn":8,"endLine":2,"endColumn":8} {"startLine":2,"startColumn":4,"endLine":2,"endColumn":4} Running: testFirstNonBlankCharacterFromWhitespace {"startLine":2,"startColumn":2,"endLine":2,"endColumn":2} {"startLine":2,"startColumn":4,"endLine":2,"endColumn":4} Running: testHomeButtonTriggering {"startLine":2,"startColumn":2,"endLine":2,"endColumn":2} {"startLine":2,"startColumn":4,"endLine":2,"endColumn":4} {"startLine":2,"startColumn":0,"endLine":2,"endColumn":0} {"startLine":2,"startColumn":4,"endLine":2,"endColumn":4} Running: testHomeButtonDoesNotChangeCursor {"startLine":0,"startColumn":2,"endLine":0,"endColumn":2} {"startLine":0,"startColumn":0,"endLine":0,"endColumn":0} {"startLine":0,"startColumn":0,"endLine":0,"endColumn":0} Running: testHomeButtonWithShift {"startLine":0,"startColumn":0,"endLine":2,"endColumn":8} {"startLine":0,"startColumn":0,"endLine":2,"endColumn":4} {"startLine":0,"startColumn":0,"endLine":2,"endColumn":4} {"startLine":0,"startColumn":0,"endLine":2,"endColumn":4} Running: testHomeButtonWithShiftInversed {"startLine":3,"startColumn":1,"endLine":2,"endColumn":8} {"startLine":3,"startColumn":1,"endLine":2,"endColumn":4} {"startLine":3,"startColumn":1,"endLine":2,"endColumn":0} {"startLine":3,"startColumn":1,"endLine":2,"endColumn":4} Diff: < {"startLine":0,"startColumn":0,"endLine":2,"endColumn":0} --- > {"startLine":0,"startColumn":0,"endLine":2,"endColumn":4}
Created attachment 187271 [details] Patch
Comment on attachment 187271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187271&action=review > LayoutTests/inspector/editor/text-editor-home-button-expected.txt:28 > +Running: testHomeButtonTriggering Toggling
Created attachment 187301 [details] Patch
Comment on attachment 187301 [details] Patch Clearing flags on attachment: 187301 Committed r142439: <http://trac.webkit.org/changeset/142439>
inspector/editor/text-editor-home-button.html is failing on Mac. I'll mark the test as [Failure], so please take a look. https://bugs.webkit.org/show_bug.cgi?id=109416
The test is failing on all Chromium Mac platforms.
*** This bug has been marked as a duplicate of bug 109416 ***
It is not correct to mark this bug as a duplicate of that one. This one is about fixing home button behavior and it is resolved fixed now. That one is about failing test.