Bug 109151 - Fix FIXME in WindowFeatures.h
Summary: Fix FIXME in WindowFeatures.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 01:01 PST by Kentaro Hara
Modified: 2013-02-07 20:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.86 KB, patch)
2013-02-07 01:02 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2013-02-07 01:03 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-07 01:01:19 PST 
1. // FIXME: We can delete this constructor once V8 showModalDialog is changed to use DOMWindow.

This FIXME is not right. The WindowFeatures() constructor is used by other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp). So we should remove the FIXME.

2. // FIXME: We can make these functions private non-member functions once V8 showModalDialog is changed to use DOMWindow.

This FIXME is fixable. Given that V8 now uses DOMWindow in showModalDialog(), we can make the methods private.
Comment 1 Kentaro Hara 2013-02-07 01:02:52 PST 
Created attachment 187013 [details]
Patch
Comment 2 Kentaro Hara 2013-02-07 01:03:44 PST 
Created attachment 187014 [details]
Patch
Comment 3 Build Bot 2013-02-07 05:43:19 PST 
Comment on attachment 187014 [details]
Patch

Attachment 187014 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16426129
Comment 4 WebKit Review Bot 2013-02-07 16:32:09 PST 
Comment on attachment 187014 [details]
Patch

Clearing flags on attachment: 187014

Committed r142202: <http://trac.webkit.org/changeset/142202>
Comment 5 WebKit Review Bot 2013-02-07 16:32:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2013-02-07 20:15:02 PST 
Comment on attachment 187014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187014&action=review

> Source/WebCore/page/WindowFeatures.h:40
> +    WindowFeatures()

Any chance we can wean the callers off this entirely? I don’t understand why this is useful.