Bug 109145 - BUILD BREAKAGE (r142064): GCC does not support assigning std::nullptr to ChildProcessProxy pointer
Summary: BUILD BREAKAGE (r142064): GCC does not support assigning std::nullptr to Chil...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: MakingBotsRed
: 109148 109153 (view as bug list)
Depends on:
Blocks: 107456 108787
  Show dependency tree / graph
 
Reported: 2013-02-07 00:36 PST by Zan Dobersek
Modified: 2013-02-07 01:33 PST (History)
12 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2013-02-07 00:38 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-02-07 00:36:30 PST 
BUILD BREAKAGE (r142064): GCC does not support assigning std::nullptr to ChildProcessProxy pointer
Comment 1 Zan Dobersek 2013-02-07 00:38:01 PST 
Created attachment 187007 [details]
Patch
Comment 2 Zan Dobersek 2013-02-07 00:51:46 PST 
The patch is pretty straightforward, using 0 instead of std::nullptr. This seem to work on mac builds due to them using clang, while the failure occurs when using gcc.

Given that the PST timezone is asleep at the moment (and will be for the next 8 hours or so) I'd recommend landing this ASAP just to remove the breakage and revisit this patch (possibly reverting it and fixing this another way) when the Apple folks get back online.
Comment 3 Csaba Osztrogonác 2013-02-07 01:03:17 PST 
*** Bug 109148 has been marked as a duplicate of this bug. ***
Comment 4 Simon Hausmann 2013-02-07 01:25:44 PST 
Comment on attachment 187007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187007&action=review

> Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:76
> -    m_process = nullptr;
> +    m_process = 0;

Could it be that this file is just missing an include of <wtf/NullPtr.h>?
Comment 5 Philippe Normand 2013-02-07 01:27:02 PST 
*** Bug 109153 has been marked as a duplicate of this bug. ***
Comment 6 Zan Dobersek 2013-02-07 01:33:00 PST 
Fixed in r142082.
http://trac.webkit.org/changeset/142082