Bug 109139 - Remove DOMWindow::parseModalDialogFeatures()
Summary: Remove DOMWindow::parseModalDialogFeatures()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 23:41 PST by Kentaro Hara
Modified: 2013-02-07 00:40 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2013-02-06 23:42 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-06 23:41:48 PST
No one uses the method. FIXME is saying:

  // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.

Given that V8's showModalDialog is now using DOMWindow, we can remove it.
Comment 1 Kentaro Hara 2013-02-06 23:42:54 PST
Created attachment 186999 [details]
Patch
Comment 2 Kent Tamura 2013-02-06 23:46:58 PST
Comment on attachment 186999 [details]
Patch

ok
Comment 3 Kentaro Hara 2013-02-07 00:40:33 PST
Committed r142075: <http://trac.webkit.org/changeset/142075>