Bug 109130 – Upstream iOS isWebThread() and isUIThread()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Upstream iOS isWebThread() and isUIThread()

[Benjamin Poulain]

Created attachment 186986 [details]
Patch

[Adam Barth]

Comment on attachment 186986 [details]
Patch

LGTM, but I don't understand in enough detail to officially review.

[Benjamin Poulain]

> (From update of attachment 186986 [details])
> LGTM, but I don't understand in enough detail to officially review.

Thanks for checking the patch. I'll ask Dave for a review.

[Build Bot]

Comment on attachment 186986 [details]
Patch

Attachment 186986 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16443020

[David Kilzer (:ddkilzer)]

Comment on attachment 186986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186986&action=review

> Source/WTF/wtf/mac/MainThreadMac.mm:148
> +#if USE(WEB_THREAD)
> +bool isUIThread()
> +{
> +    return pthread_main_np();
> +}
> +
> +bool isWebThread()
> +{
> +    return pthread_equal(pthread_self(), mainThreadPthread);
> +}
> +#endif // USE(WEB_THREAD)

I would have suggested putting these methods in an MainThreadIOS.cpp source file instead of MainThreadMac.mm.
They can be moved later if anyone else (besides me) has a strong feeling about it.

[Benjamin Poulain]

Comment on attachment 186986 [details]
Patch

Clearing flags on attachment: 186986

Committed r142163: <http://trac.webkit.org/changeset/142163>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.