Bug 109127 - Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
Summary: Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 19:37 PST by Kenneth Russell
Modified: 2013-02-11 18:40 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2013-02-06 19:40 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2013-02-11 18:06 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2013-02-06 19:37:22 PST
ddkilzer@ has pointed out several areas in ANGLE where truncation of 64-bit integer values is occurring on 64-bit platforms:

https://code.google.com/p/angleproject/issues/detail?id=403
https://code.google.com/p/angleproject/issues/detail?id=404
https://code.google.com/p/angleproject/issues/detail?id=405
https://code.google.com/p/angleproject/issues/detail?id=406
https://code.google.com/p/angleproject/issues/detail?id=407
https://code.google.com/p/angleproject/issues/detail?id=408
https://code.google.com/p/angleproject/issues/detail?id=409

In order to fix this problem, an incompatible change to ANGLE's shader translator API is needed -- replacing int with size_t in a few calls. In order to ease this change in Safari, and to allow this change to be made in the Chromium port at all, a temporary typedef is needed in ANGLEWebKitBridge.cpp to allow the code to compile both before and after this API change is made. Once both browsers have upgraded to the new version of ANGLE, the typedef can be removed, and I'll file another bug to track that cleanup.

The ANGLE upgrade is currently out for review in https://codereview.appspot.com/7300058 .
Comment 1 Kenneth Russell 2013-02-06 19:40:12 PST
Created attachment 186980 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-06 19:59:45 PST
Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16417057
Comment 3 Peter Beverloo (cr-android ews) 2013-02-06 20:31:08 PST
Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16406051
Comment 4 Build Bot 2013-02-07 00:21:05 PST
Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16415110
Comment 5 Kenneth Russell 2013-02-11 17:05:23 PST
The Android build failure is probably happening because the SH_VERSION #define in ANGLE's ShaderLang.h header is too ambiguous, and something else on the system is defining the same macro. The ANGLE patch https://codereview.appspot.com/7300058 has been updated to change the name of this macro to something less ambiguous, and I'll upload a new version of this patch which tests the new name.
Comment 6 Kenneth Russell 2013-02-11 18:06:55 PST
Created attachment 187740 [details]
Patch
Comment 7 WebKit Review Bot 2013-02-11 18:40:34 PST
Comment on attachment 187740 [details]
Patch

Clearing flags on attachment: 187740

Committed r142567: <http://trac.webkit.org/changeset/142567>
Comment 8 WebKit Review Bot 2013-02-11 18:40:37 PST
All reviewed patches have been landed.  Closing bug.