Bug 109127 – Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

ddkilzer@ has pointed out several areas in ANGLE where truncation of 64-bit integer values is occurring on 64-bit platforms:

https://code.google.com/p/angleproject/issues/detail?id=403
https://code.google.com/p/angleproject/issues/detail?id=404
https://code.google.com/p/angleproject/issues/detail?id=405
https://code.google.com/p/angleproject/issues/detail?id=406
https://code.google.com/p/angleproject/issues/detail?id=407
https://code.google.com/p/angleproject/issues/detail?id=408
https://code.google.com/p/angleproject/issues/detail?id=409

In order to fix this problem, an incompatible change to ANGLE's shader translator API is needed -- replacing int with size_t in a few calls. In order to ease this change in Safari, and to allow this change to be made in the Chromium port at all, a temporary typedef is needed in ANGLEWebKitBridge.cpp to allow the code to compile both before and after this API change is made. Once both browsers have upgraded to the new version of ANGLE, the typedef can be removed, and I'll file another bug to track that cleanup.

The ANGLE upgrade is currently out for review in https://codereview.appspot.com/7300058 .

[Kenneth Russell]

Created attachment 186980 [details]
Patch

[WebKit Review Bot]

Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16417057

[Peter Beverloo (cr-android ews)]

Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16406051

[Build Bot]

Comment on attachment 186980 [details]
Patch

Attachment 186980 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16415110

[Kenneth Russell]

The Android build failure is probably happening because the SH_VERSION #define in ANGLE's ShaderLang.h header is too ambiguous, and something else on the system is defining the same macro. The ANGLE patch https://codereview.appspot.com/7300058 has been updated to change the name of this macro to something less ambiguous, and I'll upload a new version of this patch which tests the new name.

[Kenneth Russell]

Created attachment 187740 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187740 [details]
Patch

Clearing flags on attachment: 187740

Committed r142567: <http://trac.webkit.org/changeset/142567>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.