Bug 109119 - Fix build warning after r142017
Summary: Fix build warning after r142017
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KwangYong Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 18:07 PST by KwangYong Choi
Modified: 2014-02-13 00:47 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2013-02-06 18:09 PST, KwangYong Choi
no flags Details | Formatted Diff | Diff
second try at fixing builds (42.17 KB, patch)
2014-02-12 07:27 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2013-02-06 18:07:25 PST
/home/cky/open-source/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:1224:6: warning: unused parameter ‘documentURLString’ [-Wunused-parameter]
Comment 1 KwangYong Choi 2013-02-06 18:09:46 PST
Created attachment 186967 [details]
Patch
Comment 2 Kentaro Hara 2013-02-07 04:13:24 PST
Comment on attachment 186967 [details]
Patch

LGTM, but it requires review from a WebKit2 owner, sorry:(
Comment 3 KwangYong Choi 2013-02-07 04:15:37 PST
(In reply to comment #2)
> (From update of attachment 186967 [details])
> LGTM, but it requires review from a WebKit2 owner, sorry:(

Thank you. :)
Comment 4 WebKit Review Bot 2013-02-07 16:29:07 PST
Comment on attachment 186967 [details]
Patch

Clearing flags on attachment: 186967

Committed r142201: <http://trac.webkit.org/changeset/142201>
Comment 5 WebKit Review Bot 2013-02-07 16:29:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 youenn fablet 2014-02-12 07:27:51 PST
Reopening to attach new patch.
Comment 7 youenn fablet 2014-02-12 07:27:56 PST
Created attachment 223970 [details]
second try at fixing builds
Comment 8 youenn fablet 2014-02-12 07:29:50 PST
Uploaded patch for wrong bug, please disregard this second patch.