Bug 109101 - Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
Summary: Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dima Gorbik
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-06 15:29 PST by Dima Gorbik
Modified: 2013-02-06 16:32 PST (History)
4 users (show)

See Also:

Attachments
Proposed fix 0.1 (1.49 KB, patch)
2013-02-06 15:36 PST, Dima Gorbik 		joepeck: review+
Details | Formatted Diff | Diff
Proposed fix 0.2 (1.46 KB, patch)
2013-02-06 15:42 PST, Dima Gorbik 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Gorbik 2013-02-06 15:29:34 PST 
We check that the style matches a pseudo element by setting its height to 1px. But if there was a border property set in default styles the minimum height will be 2px, so the test will fail. We need to reset this property.
Comment 1 Radar WebKit Bug Importer 2013-02-06 15:29:45 PST 
<rdar://problem/13166872>
Comment 2 Dima Gorbik 2013-02-06 15:36:19 PST 
Created attachment 186935 [details]
Proposed fix 0.1
Comment 3 Joseph Pecoraro 2013-02-06 15:38:40 PST 
Comment on attachment 186935 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=186935&action=review

r=me

> LayoutTests/ChangeLog:8
> +        We need to reset this property.

You could call out a sample user agent "Some user agents, like iOS, have default border styles that affect the minimum height".
Comment 4 Dima Gorbik 2013-02-06 15:42:12 PST 
Created attachment 186937 [details]
Proposed fix 0.2
Comment 5 Joseph Pecoraro 2013-02-06 15:43:27 PST 
Comment on attachment 186937 [details]
Proposed fix 0.2

r=me
Comment 6 WebKit Review Bot 2013-02-06 16:32:52 PST 
Comment on attachment 186937 [details]
Proposed fix 0.2

Clearing flags on attachment: 186937

Committed r142052: <http://trac.webkit.org/changeset/142052>
Comment 7 WebKit Review Bot 2013-02-06 16:32:56 PST 
All reviewed patches have been landed.  Closing bug.