Bug 109092 – IndexedDB: Implement SharedBuffer version of put()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

IndexedDB: Implement SharedBuffer version of put()

[Alec Flett]

Created attachment 186923 [details]
Patch

[Alec Flett]

jsbell/dgrogan - here's the first cut at using SharedBuffer

abarth - care to review - not just the WebKit API but my uses in core IDB?

[Alec Flett]

Also I fully expect this patch to fail dramatically (not sure why cr-linux-debug even passed) until the chromium side (https://codereview.chromium.org/12217049/) lands.

[Adam Barth]

Comment on attachment 186923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186923&action=review

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:234
> +    Vector<char>* valueBytesSigned = reinterpret_cast<Vector<char>*>(&valueBytes);

Is this reinterpret_cast valid?  It seems slightly scary.

[Adam Barth]

Comment on attachment 186923 [details]
Patch

This seems fine, modulo the question about reinterpret_cast above.

[Alec Flett]

Comment on attachment 186923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186923&action=review

>> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:234
>> +    Vector<char>* valueBytesSigned = reinterpret_cast<Vector<char>*>(&valueBytes);
> 
> Is this reinterpret_cast valid?  It seems slightly scary.

It's totally scary. It was the only way I could find to adopt a Vector<uint8_t> into SharedBuffer.

[Adam Barth]

> It's totally scary. It was the only way I could find to adopt a Vector<uint8_t> into SharedBuffer.

On webkit-dev you talked about changing Vector<uint8_t> to Vector<char>.  Folks seemed unsure about whether that was a good idea because the reason was to play nice with LevelDB.  Perhaps playing nice with SharedBuffer is a reason that tips the scales in favor of switching to Vector<char>.

[Alec Flett]

Created attachment 188620 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 188620 [details]
Patch for landing

Clearing flags on attachment: 188620

Committed r143037: <http://trac.webkit.org/changeset/143037>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.