Bug 109079 - [Text Autosizing] Cleanup change: converted the pointer argument to be a reference since non-null pointer is always expected
Summary: [Text Autosizing] Cleanup change: converted the pointer argument to be a refe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Unspecified
: P2 Normal
Assignee: Anton Vayvod
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 11:32 PST by Anton Vayvod
Modified: 2013-02-09 10:35 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.21 KB, patch)
2013-02-06 11:34 PST, Anton Vayvod
no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2013-02-08 12:24 PST, Anton Vayvod
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Vayvod 2013-02-06 11:32:09 PST
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since non-null pointer is always expected
Comment 1 Anton Vayvod 2013-02-06 11:34:46 PST
Created attachment 186884 [details]
Patch
Comment 2 Julien Chaffraix 2013-02-06 11:48:26 PST
Comment on attachment 186884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186884&action=review

> Source/WebCore/rendering/TextAutosizer.cpp:298
>      TextAutosizingClusterInfo emptyClusterInfo(0);
> -    return isAutosizingContainer(object) && isAutosizingCluster(toRenderBlock(object), &emptyClusterInfo);
> +    return isAutosizingContainer(object) && isAutosizingCluster(toRenderBlock(object), emptyClusterInfo);

Mentioned on bug 109054, I would rather see isAutosizingCluster take a pointer that can be NULL instead of having an empty object. That would remove the need for this overriden method.
Comment 3 Build Bot 2013-02-06 15:55:53 PST
Comment on attachment 186884 [details]
Patch

Attachment 186884 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16387485
Comment 4 Anton Vayvod 2013-02-08 12:24:31 PST
Created attachment 187347 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-09 10:35:39 PST
Comment on attachment 187347 [details]
Patch

Clearing flags on attachment: 187347

Committed r142367: <http://trac.webkit.org/changeset/142367>
Comment 6 WebKit Review Bot 2013-02-09 10:35:43 PST
All reviewed patches have been landed.  Closing bug.