Bug 109072 - IndexedDB: De-flake open-during-transaction layout test
Summary: IndexedDB: De-flake open-during-transaction layout test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 11:05 PST by Joshua Bell
Modified: 2013-02-08 14:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2013-02-06 11:10 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2013-02-06 11:05:48 PST 
IndexedDB: De-flake open-during-transaction layout test
Comment 1 Joshua Bell 2013-02-06 11:10:17 PST 
Created attachment 186879 [details]
Patch
Comment 2 Joshua Bell 2013-02-06 11:18:37 PST 
dgrogan@, alecflett@ - can you take a look?

I saw this flake when doing repeated runs of the storage/indexeddb tests. I was actually surprised to see this flake under DRT (single-process) as opposed to content_shell (multi-process), but I believe it's due to the timing of the open() calls occurring in event callbacks vs. the transaction timer. (I also moved my /tmp dir to a ramdisk so the opens() take less wall-clock time on my machine.) I don't know if it's worth digging in further.

The test was first added in wkrev.com/98749 to act as a canary for crashes around with metadata snapshotting. Since then that whole mechanism has changed and there are dedicated tests and setVersion() has been removed. So I think the remaining purpose of this test is merely "make sure open()-with-no-version isn't blocked on a running transaction". 

This seems trivial but weird, so feedback appreciated.
Comment 3 Alec Flett 2013-02-06 14:22:53 PST 
lgtm
Comment 4 David Grogan 2013-02-06 17:39:56 PST 
lgtm2
Comment 5 Joshua Bell 2013-02-08 14:39:18 PST 
tony@ - when convenient, r? cq?
Comment 6 WebKit Review Bot 2013-02-08 14:50:23 PST 
Comment on attachment 186879 [details]
Patch

Clearing flags on attachment: 186879

Committed r142324: <http://trac.webkit.org/changeset/142324>
Comment 7 WebKit Review Bot 2013-02-08 14:50:26 PST 
All reviewed patches have been landed.  Closing bug.