RESOLVED FIXED 109059
[BlackBerry] Refactor renderContents() for cleaner code 
https://bugs.webkit.org/show_bug.cgi?id=109059
Summary [BlackBerry] Refactor renderContents() for cleaner code
Jakob Petsovits
Reported 2013-02-06 08:53:10 PST
The fact that we've got two renderContents() implementations in BackingStore.cpp, one of which was tailored to just being called from drawContents(), is a major annoyance. With this patch, the regular renderContents() is modified in a way so that drawContents() can make use of it as well. This includes an API change for both functions which makes it more flexible and enables further cleanups and improvements to accuracy. The second, unloved renderContents() is removed. The user-visible changes are improved (float) accuracy for render offsets, clipping to exactly the dstRect that has been specified, and the changed public drawContents() API. Patch below, already reviewed by Arvid Nilsson in our internal bugtracker (thanks).
Attachments
Patch (23.88 KB, patch)
2013-02-06 09:17 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-02-06 09:17:47 PST
Created attachment 186869 [details] Patch
Rob Buis
Comment 2 2013-02-06 14:26:24 PST
Comment on attachment 186869 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2013-02-06 14:48:18 PST
Comment on attachment 186869 [details] Patch Clearing flags on attachment: 186869 Committed r142037: <http://trac.webkit.org/changeset/142037>
WebKit Review Bot
Comment 4 2013-02-06 14:48:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.