Bug 109059 - [BlackBerry] Refactor renderContents() for cleaner code
Summary: [BlackBerry] Refactor renderContents() for cleaner code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 08:53 PST by Jakob Petsovits
Modified: 2013-02-06 14:48 PST (History)
8 users (show)

See Also:


Attachments
Patch (23.88 KB, patch)
2013-02-06 09:17 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-02-06 08:53:10 PST
The fact that we've got two renderContents() implementations in BackingStore.cpp, one of which was tailored to just being called from drawContents(), is a major annoyance.

With this patch, the regular renderContents() is modified in a way so that drawContents() can make use of it as well. This includes an API change for both functions which makes it more flexible and enables further cleanups and improvements to accuracy. The second, unloved renderContents() is removed.

The user-visible changes are improved (float) accuracy for render offsets, clipping to exactly the dstRect that has been specified, and the changed public drawContents() API.

Patch below, already reviewed by Arvid Nilsson in our internal bugtracker (thanks).
Comment 1 Jakob Petsovits 2013-02-06 09:17:47 PST
Created attachment 186869 [details]
Patch
Comment 2 Rob Buis 2013-02-06 14:26:24 PST
Comment on attachment 186869 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-02-06 14:48:18 PST
Comment on attachment 186869 [details]
Patch

Clearing flags on attachment: 186869

Committed r142037: <http://trac.webkit.org/changeset/142037>
Comment 4 WebKit Review Bot 2013-02-06 14:48:22 PST
All reviewed patches have been landed.  Closing bug.