Bug 109042 - Web Inspector: Native Memory Instrumentation: provide name property for DOM Element and Attribute nodes.
Summary: Web Inspector: Native Memory Instrumentation: provide name property for DOM E...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 107254
  Show dependency tree / graph
 
Reported: 2013-02-06 05:21 PST by Ilya Tikhonovsky
Modified: 2013-04-08 12:27 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2013-02-06 05:28 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-02-06 05:21:54 PST 
EOM
Comment 1 Ilya Tikhonovsky 2013-02-06 05:28:54 PST 
Created attachment 186836 [details]
Patch
Comment 2 Yury Semikhatsky 2013-02-08 00:22:47 PST 
Comment on attachment 186836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186836&action=review

> Source/WebCore/dom/Element.cpp:2827
> +    memoryObjectInfo->setName(buildElementSelectorString(this).utf8().data());

This may have a noticeable performance impact which should be avoided in the cases when we don't collect heap graph.
Comment 3 Pavel Feldman 2013-03-19 09:53:39 PDT 
Comment on attachment 186836 [details]
Patch

Clearing r? - it has been there for ages, probably obsolete.