for now, we'll stick with the mocks
Created attachment 187526 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 187526 [details] Patch Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16497116 New failing tests: fast/mediastream/RTCPeerConnection-statsSelector.html fast/mediastream/RTCPeerConnection-stats.html
Comment on attachment 187526 [details] Patch Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16488225 New failing tests: fast/mediastream/RTCPeerConnection-statsSelector.html fast/mediastream/RTCPeerConnection-stats.html
The tests fail because of a bug in webkit_support. Fix here: https://codereview.chromium.org/12212107
Comment on attachment 187526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187526&action=review > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:91 > + MockWebKitPlatformSupport* getMockPlatform() { return m_mockPlatform.get(); } getMockPlatform -> mockPlatform (we tend to skip the "get" prefix)
Created attachment 187787 [details] Patch for landing
Comment on attachment 187787 [details] Patch for landing Clearing flags on attachment: 187787 Committed r142593: <http://trac.webkit.org/changeset/142593>
All reviewed patches have been landed. Closing bug.