Bug 109041 - [chromium] move webrtc mocks to testrunner library
Summary: [chromium] move webrtc mocks to testrunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency treegraph
 
Reported: 2013-02-06 05:20 PST by jochen
Modified: 2013-02-12 00:49 PST (History)
7 users (show)

See Also:


Attachments
Patch (130.03 KB, patch)
2013-02-11 01:41 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (131.29 KB, patch)
2013-02-12 00:11 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-06 05:20:39 PST
for now, we'll stick with the mocks
Comment 1 jochen 2013-02-11 01:41:51 PST
Created attachment 187526 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-11 01:50:46 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-02-11 02:58:04 PST
Comment on attachment 187526 [details]
Patch

Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16497116

New failing tests:
fast/mediastream/RTCPeerConnection-statsSelector.html
fast/mediastream/RTCPeerConnection-stats.html
Comment 4 WebKit Review Bot 2013-02-11 03:32:32 PST
Comment on attachment 187526 [details]
Patch

Attachment 187526 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16488225

New failing tests:
fast/mediastream/RTCPeerConnection-statsSelector.html
fast/mediastream/RTCPeerConnection-stats.html
Comment 5 jochen 2013-02-11 04:16:11 PST
The tests fail because of a bug in webkit_support. Fix here: https://codereview.chromium.org/12212107
Comment 6 Adam Barth 2013-02-11 10:35:00 PST
Comment on attachment 187526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187526&action=review

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:91
> +    MockWebKitPlatformSupport* getMockPlatform() { return m_mockPlatform.get(); }

getMockPlatform -> mockPlatform (we tend to skip the "get" prefix)
Comment 7 jochen 2013-02-12 00:11:20 PST
Created attachment 187787 [details]
Patch for landing
Comment 8 WebKit Review Bot 2013-02-12 00:49:20 PST
Comment on attachment 187787 [details]
Patch for landing

Clearing flags on attachment: 187787

Committed r142593: <http://trac.webkit.org/changeset/142593>
Comment 9 WebKit Review Bot 2013-02-12 00:49:24 PST
All reviewed patches have been landed.  Closing bug.