Bug 109039 – [V8] Rename isolated() to getWorld(), rename worldForEnteredContextIfIsolated() to worldForEnteredContext()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

For naming consistency, rename isolated() to getWorld() and rename worldForEnteredContextIfIsolated() to worldForEnteredContext().

[Kentaro Hara]

Created attachment 186816 [details]
Patch

[WebKit Review Bot]

Comment on attachment 186816 [details]
Patch

Attachment 186816 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16388281

[Adam Barth]

Comment on attachment 186816 [details]
Patch

Looks like the cr-linux-debug bot is unhappy with this patch.

[Kentaro Hara]

Created attachment 187009 [details]
patch for landing

[Kentaro Hara]

Comment on attachment 187009 [details]
patch for landing

A patch which this patch depends on was rolled out.

[Kentaro Hara]

Committed r142424: <http://trac.webkit.org/changeset/142424>

[Dan Carney]

This change makes no sense.  The function on DOMWrapperWorld only returns an isolated world.  It does that for performance.  This leads to semantic ambiguity like in V8GCController::minorGCPrologue:

        DOMWrapperWorld* world = worldForEnteredContextWithoutContextCheck();
        if (world && world->isMainWorld()) {

the branch will never be taken and minor gc is disabled because of this.

Please consider this reverting this renaming.

[Kentaro Hara]

ah... This was a big mistake. Let me revert them.

Because we're limiting the number of nodes handled by each minor GC to 10000, I couldn't detect the performance regression by Dromaeo/dom-modify...