RESOLVED WONTFIX 109035
[WTFURL] Add the URLUtilities unit test 
https://bugs.webkit.org/show_bug.cgi?id=109035
Summary [WTFURL] Add the URLUtilities unit test
Zan Dobersek
Reported 2013-02-06 02:56:44 PST
[WTFURL] Add the URLUtilities unit test
Attachments
Patch (12.31 KB, patch)
2013-02-06 02:59 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (12.39 KB, patch)
2013-04-03 10:24 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-06 02:59:20 PST
Created attachment 186809 [details] Patch
WebKit Review Bot
Comment 2 2013-02-06 03:01:34 PST
Attachment 186809 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/GNUmakefile.am', u'Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp']" exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp:168: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b) [readability/check] [2] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-02-06 07:30:12 PST
Comment on attachment 186809 [details] Patch Attachment 186809 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16391295
Zan Dobersek
Comment 4 2013-02-06 09:04:49 PST
(In reply to comment #2) > Attachment 186809 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/GNUmakefile.am', u'Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp']" exit_code: 1 > Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp:168: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b) [readability/check] [2] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. EXPECT_NE doesn't work in this case due to unconventional argument types, so EXPECT_TRUE is used here to test that the operands are not equal. (In reply to comment #3) > (From update of attachment 186809 [details]) > Attachment 186809 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16391295 Irrelevant, the win-ews is quite unstable these days.
Zan Dobersek
Comment 5 2013-02-06 09:05:43 PST
The GTK EWS failure is valid, the patch fixing that is up in bug #109040.
Zan Dobersek
Comment 6 2013-04-03 10:24:21 PDT
Created attachment 196371 [details] Patch
WebKit Review Bot
Comment 7 2013-04-03 10:26:31 PDT
Attachment 196371 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/GNUmakefile.am', u'Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp']" exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/url/URLUtil.cpp:168: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b) [readability/check] [2] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.