Bug 109008 - AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
Summary: AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-05 22:38 PST by chris fleizach
Modified: 2013-02-06 12:10 PST (History)
7 users (show)

See Also:

Attachments
patch (4.43 KB, patch)
2013-02-05 23:07 PST, chris fleizach 		rniwa: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (5.56 KB, patch)
2013-02-06 11:38 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-02-05 22:38:42 PST 
If you do 
<html aria-label="test">

then the <html> element becomes an AXGroup in the AX hierarchy. 

We should not be exposing the <html> element because it adds another layer in the AX hierarchy for no reason, and can confuse screen readers
Comment 1 chris fleizach 2013-02-05 22:38:55 PST 
rdar://13130243
Comment 2 chris fleizach 2013-02-05 23:07:52 PST 
Created attachment 186763 [details]
patch
Comment 3 Ryosuke Niwa 2013-02-06 01:14:20 PST 
Comment on attachment 186763 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186763&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2592
> +    

Nit: spaces.

> LayoutTests/accessibility/html-html-element-is-ignored.html:20
> +        }

It would have been helpful if you printed a message like debug("This test requires accessibilityController"); so that a person who opened this file manually on a browser can tell why the test is not running.
Comment 4 WebKit Review Bot 2013-02-06 01:23:05 PST 
Comment on attachment 186763 [details]
patch

Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16378990

New failing tests:
accessibility/html-html-element-is-ignored.html
Comment 5 WebKit Review Bot 2013-02-06 02:21:58 PST 
Comment on attachment 186763 [details]
patch

Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16389170

New failing tests:
accessibility/html-html-element-is-ignored.html
Comment 6 chris fleizach 2013-02-06 08:04:31 PST 
(In reply to comment #5)
> (From update of attachment 186763 [details])
> Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/16389170
> 
> New failing tests:
> accessibility/html-html-element-is-ignored.html

chromium has a different element besides a web area I think, so I'll skip this test for cr for now
Comment 7 chris fleizach 2013-02-06 08:35:54 PST 
(In reply to comment #3)
> (From update of attachment 186763 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186763&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2592
> > +    
> 
> Nit: spaces.
> 
> > LayoutTests/accessibility/html-html-element-is-ignored.html:20
> > +        }
> 
> It would have been helpful if you printed a message like debug("This test requires accessibilityController"); so that a person who opened this file manually on a browser can tell why the test is not running.

done and done. thanks
Comment 8 chris fleizach 2013-02-06 11:38:09 PST 
Created attachment 186886 [details]
patch for landing
Comment 9 chris fleizach 2013-02-06 12:10:36 PST 
http://trac.webkit.org/changeset/142014