Bug 109002 - [BlackBerry] Export mimeType in NetworkJob
Summary: [BlackBerry] Export mimeType in NetworkJob
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 20:13 PST by Mary Wu
Modified: 2013-02-07 07:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2013-02-05 20:23 PST, Mary Wu
no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2013-02-06 02:48 PST, Mary Wu
no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2013-02-06 18:50 PST, Mary Wu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2013-02-05 20:13:42 PST
NetworkJob will analysize resource mimetype and set it to resourceResponse, we will pass it on to be used by other Streams like download stream.
Comment 1 Mary Wu 2013-02-05 20:23:04 PST
Created attachment 186750 [details]
Patch
Comment 2 Mary Wu 2013-02-06 02:48:58 PST
Created attachment 186806 [details]
Patch
Comment 3 Yong Li 2013-02-06 06:51:39 PST
Comment on attachment 186806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958
> +const BlackBerry::Platform::String NetworkJob::mimeType() const
> +{
> +    String type = m_response.mimeType();
> +
> +    return type.isEmpty() ? "" : type.utf8().data();
> +}

Why do we have to use utf8()? This always creates a new CString
Comment 4 Mary Wu 2013-02-06 18:44:31 PST
(In reply to comment #3)
> (From update of attachment 186806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review
> 
> > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958
> > +const BlackBerry::Platform::String NetworkJob::mimeType() const
> > +{
> > +    String type = m_response.mimeType();
> > +
> > +    return type.isEmpty() ? "" : type.utf8().data();
> > +}
> 
> Why do we have to use utf8()? This always creates a new CString

nice, looks we already implemented that in StringBlackBerry. thanks
Comment 5 Mary Wu 2013-02-06 18:50:25 PST
Created attachment 186977 [details]
Patch
Comment 6 WebKit Review Bot 2013-02-07 07:07:02 PST
Comment on attachment 186977 [details]
Patch

Clearing flags on attachment: 186977

Committed r142115: <http://trac.webkit.org/changeset/142115>
Comment 7 WebKit Review Bot 2013-02-07 07:07:07 PST
All reviewed patches have been landed.  Closing bug.