Bug 109002 – [BlackBerry] Export mimeType in NetworkJob

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Mary Wu]

NetworkJob will analysize resource mimetype and set it to resourceResponse, we will pass it on to be used by other Streams like download stream.

[Mary Wu]

Created attachment 186750 [details]
Patch

[Mary Wu]

Created attachment 186806 [details]
Patch

[Yong Li]

Comment on attachment 186806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958
> +const BlackBerry::Platform::String NetworkJob::mimeType() const
> +{
> +    String type = m_response.mimeType();
> +
> +    return type.isEmpty() ? "" : type.utf8().data();
> +}

Why do we have to use utf8()? This always creates a new CString

[Mary Wu]

(In reply to comment #3)
> (From update of attachment 186806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review
> 
> > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958
> > +const BlackBerry::Platform::String NetworkJob::mimeType() const
> > +{
> > +    String type = m_response.mimeType();
> > +
> > +    return type.isEmpty() ? "" : type.utf8().data();
> > +}
> 
> Why do we have to use utf8()? This always creates a new CString

nice, looks we already implemented that in StringBlackBerry. thanks

[Mary Wu]

Created attachment 186977 [details]
Patch

[WebKit Review Bot]

Comment on attachment 186977 [details]
Patch

Clearing flags on attachment: 186977

Committed r142115: <http://trac.webkit.org/changeset/142115>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.