RESOLVED FIXED109001
[V8] Pass an Isolate to remaining GetTemplate()s 
https://bugs.webkit.org/show_bug.cgi?id=109001
Summary [V8] Pass an Isolate to remaining GetTemplate()s
Kentaro Hara
Reported 2013-02-05 20:08:20 PST
I think I can make an Isolate mandatory in GetTemplate() in the next patch.
Attachments
Patch (19.21 KB, patch)
2013-02-05 20:09 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-05 20:09:51 PST
Created attachment 186748 [details] Patch
Build Bot
Comment 2 2013-02-05 22:38:56 PST
Comment on attachment 186748 [details] Patch Attachment 186748 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16386143
Adam Barth
Comment 3 2013-02-06 00:23:48 PST
Comment on attachment 186748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186748&action=review > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:512 > + v8::Isolate* isolate = v8::Isolate::GetCurrent(); V8 doesn't give us the isolate in this callback?
Kentaro Hara
Comment 4 2013-02-06 00:25:33 PST
Comment on attachment 186748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186748&action=review >> Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:512 >> + v8::Isolate* isolate = v8::Isolate::GetCurrent(); > > V8 doesn't give us the isolate in this callback? No, for now. This should be fixed but it will take time. (Recently we implemented an isolate-version callback for WeakCallback().)
WebKit Review Bot
Comment 5 2013-02-06 00:56:57 PST
Comment on attachment 186748 [details] Patch Clearing flags on attachment: 186748 Committed r141977: <http://trac.webkit.org/changeset/141977>
WebKit Review Bot
Comment 6 2013-02-06 00:57:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.