I think I can make an Isolate mandatory in GetTemplate() in the next patch.
Created attachment 186748 [details] Patch
Comment on attachment 186748 [details] Patch Attachment 186748 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16386143
Comment on attachment 186748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186748&action=review > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:512 > + v8::Isolate* isolate = v8::Isolate::GetCurrent(); V8 doesn't give us the isolate in this callback?
Comment on attachment 186748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186748&action=review >> Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:512 >> + v8::Isolate* isolate = v8::Isolate::GetCurrent(); > > V8 doesn't give us the isolate in this callback? No, for now. This should be fixed but it will take time. (Recently we implemented an isolate-version callback for WeakCallback().)
Comment on attachment 186748 [details] Patch Clearing flags on attachment: 186748 Committed r141977: <http://trac.webkit.org/changeset/141977>
All reviewed patches have been landed. Closing bug.