Bug 108997 – More updates to Caption user preferences

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Refine the code the Mac port uses to modify caption and subtitle style.

[Radar WebKit Bug Importer]

<rdar://problem/13159553>

[Eric Carlson]

Created attachment 186743 [details]
Proposed patch

[Dean Jackson]

Comment on attachment 186743 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186743&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Remove this line. I guess technically we could test some of these if we toggled captions on, scrubbed the media and then were able to dump the shadow root for the captions.

> Source/WebCore/page/CaptionUserPreferencesMac.mm:151
> +    builder.append(": .2em");

Does this value come from the spec? It might be better as a defined constant somewhere.

> Source/WebCore/page/CaptionUserPreferencesMac.mm:224
>      builder.append(':');
> -    builder.append(String::format("%.02f", radius));
> +    builder.append(String::format("%.02fpx", radius));

Maybe combine the ":" into String::format?

[Build Bot]

Comment on attachment 186743 [details]
Proposed patch

Attachment 186743 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16388093

[Eric Carlson]

(In reply to comment #4)
> (From update of attachment 186743 [details])
> Attachment 186743 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16388093

I don't think so:

1>####### COMPILING 1 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ###########
1>ImageDiffCG.cpp
1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory

[Eric Carlson]

Committed r141966: <http://trac.webkit.org/changeset/141966>