Bug 108993 - IndexedDB: Stub out SharedBuffer version of get()
Summary: IndexedDB: Stub out SharedBuffer version of get()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 17:17 PST by Alec Flett
Modified: 2019-05-02 16:19 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.44 KB, patch)
2013-02-05 17:19 PST, Alec Flett 		no flags Details | Formatted Diff | Diff
Patch for landing (3.77 KB, patch)
2013-02-15 14:06 PST, Alec Flett 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2013-02-05 17:17:46 PST 
IndexedDB: Stub out SharedBuffer version of get()
Comment 1 Alec Flett 2013-02-05 17:19:04 PST 
Created attachment 186728 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-05 17:20:43 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-02-05 17:27:21 PST 
Comment on attachment 186728 [details]
Patch

Attachment 186728 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16374946
Comment 4 WebKit Review Bot 2013-02-05 17:44:40 PST 
Comment on attachment 186728 [details]
Patch

Attachment 186728 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16376956
Comment 5 Peter Beverloo (cr-android ews) 2013-02-05 17:49:24 PST 
Comment on attachment 186728 [details]
Patch

Attachment 186728 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16374959
Comment 6 Darin Fisher (:fishd, Google) 2013-02-05 23:39:47 PST 
Comment on attachment 186728 [details]
Patch

Looks like you need to forward declare WebData.  R+ with that fix.
Comment 7 Alec Flett 2013-02-15 14:06:28 PST 
Created attachment 188640 [details]
Patch for landing
Comment 8 WebKit Review Bot 2013-02-15 14:49:42 PST 
Comment on attachment 188640 [details]
Patch for landing

Clearing flags on attachment: 188640

Committed r143055: <http://trac.webkit.org/changeset/143055>
Comment 9 WebKit Review Bot 2013-02-15 14:49:46 PST 
All reviewed patches have been landed.  Closing bug.