Bug 108989 - [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
Summary: [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Dorwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 16:15 PST by David Dorwin
Modified: 2013-02-05 17:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2013-02-05 16:18 PST, David Dorwin
no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2013-02-05 17:12 PST, David Dorwin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Dorwin 2013-02-05 16:15:33 PST
[chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
Comment 1 David Dorwin 2013-02-05 16:18:03 PST
Created attachment 186722 [details]
Patch
Comment 2 David Dorwin 2013-02-05 16:24:14 PST
scherkus says LGTM, but I need an R+.
Comment 3 Kent Tamura 2013-02-05 17:06:36 PST
Comment on attachment 186722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112
> +    // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin()

TODO() -> FIXME
Comment 4 David Dorwin 2013-02-05 17:12:02 PST
Created attachment 186727 [details]
Patch
Comment 5 David Dorwin 2013-02-05 17:12:34 PST
Comment on attachment 186722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review

>> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112
>> +    // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin()
> 
> TODO() -> FIXME

Done.
Comment 6 Kent Tamura 2013-02-05 17:19:04 PST
Comment on attachment 186727 [details]
Patch

ok
Comment 7 WebKit Review Bot 2013-02-05 17:43:43 PST
Comment on attachment 186727 [details]
Patch

Clearing flags on attachment: 186727

Committed r141954: <http://trac.webkit.org/changeset/141954>
Comment 8 WebKit Review Bot 2013-02-05 17:43:46 PST
All reviewed patches have been landed.  Closing bug.