Bug 108988 - Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS() + make DatabaseType a strong enum
Summary: Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS() + make DatabaseType a strong ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 107475
  Show dependency tree / graph
 
Reported: 2013-02-05 16:04 PST by Mark Lam
Modified: 2013-02-05 17:01 PST (History)
7 users (show)

See Also:

Attachments
the patch. (6.24 KB, patch)
2013-02-05 16:08 PST, Mark Lam 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-02-05 16:04:05 PST 
Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS(), and make DatabaseType a strong enum.
Comment 1 Mark Lam 2013-02-05 16:08:59 PST 
Created attachment 186720 [details]
the patch.
Comment 2 Mark Lam 2013-02-05 16:10:41 PST 
Here's another small EnumClass patch.  May I have a review please?  Thanks.
Comment 3 WebKit Review Bot 2013-02-05 16:12:05 PST 
Attachment 186720 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/EnumClass.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.h', u'Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackendSync.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h', u'Source/WebCore/Modules/webdatabase/DatabaseError.h']" exit_code: 1
Source/WebCore/Modules/webdatabase/DatabaseError.h:35:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h:38:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2013-02-05 17:01:40 PST 
Thanks for the review.  Landed in r141950: <http://trac.webkit.org/changeset/141950>.