This method used to be Mac specific because it was returning NSWritingDirection. After http://trac.webkit.org/changeset/141513 the same method now returns WritingDirection which is a WebCore type. We want to move this to Editor.cpp so that we can use it for iOS as well.
Created attachment 186703 [details] Patch
Comment on attachment 186703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review > Source/WebCore/editing/Editor.cpp:1345 > + result = LeftToRightWritingDirection; > + break; I know you're just moving an existing code but we can just return here. > Source/WebCore/editing/Editor.cpp:1348 > + result = RightToLeftWritingDirection; > + break; Ditto.
(In reply to comment #2) > (From update of attachment 186703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review > > > Source/WebCore/editing/Editor.cpp:1345 > > + result = LeftToRightWritingDirection; > > + break; > > I know you're just moving an existing code but we can just return here. > > > Source/WebCore/editing/Editor.cpp:1348 > > + result = RightToLeftWritingDirection; > > + break; > > Ditto. I agree. Thanks for the review!
Committed revision 141937.