Bug 108977 – Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

This method used to be Mac specific because it was returning NSWritingDirection.
After http://trac.webkit.org/changeset/141513 the same method now returns WritingDirection which is a WebCore type.
We want to move this to Editor.cpp so that we can use it for iOS as well.

[Enrica Casucci]

Created attachment 186703 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 186703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review

> Source/WebCore/editing/Editor.cpp:1345
> +        result = LeftToRightWritingDirection;
> +        break;

I know you're just moving an existing code but we can just return here.

> Source/WebCore/editing/Editor.cpp:1348
> +        result = RightToLeftWritingDirection;
> +        break;

Ditto.

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 186703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review
> 
> > Source/WebCore/editing/Editor.cpp:1345
> > +        result = LeftToRightWritingDirection;
> > +        break;
> 
> I know you're just moving an existing code but we can just return here.
> 
> > Source/WebCore/editing/Editor.cpp:1348
> > +        result = RightToLeftWritingDirection;
> > +        break;
> 
> Ditto.

I agree. Thanks for the review!

[Enrica Casucci]

Committed revision 141937.