Bug 108969 – formenctype to have empty string as default value.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Vineet Chaudhary (vineetc)]

Specification : http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formenctype
              : http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-formenctype
              : https://bugzilla.mozilla.org/show_bug.cgi?id=787095

The spec says formEnctype should only have an invalid value default, not a missing value default.
Tests affected : fast/forms/submit-form-attributes.html

[Vineet Chaudhary (vineetc)]

Created attachment 186684 [details]
patch

As per discussion from bug https://bugs.webkit.org/show_bug.cgi?id=108263
Modified test case fast/forms/submit-form-attributes.html to replace 
shouldBe() with shouldBeEqualToString()

[Kent Tamura]

Comment on attachment 186684 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186684&action=review

> LayoutTests/fast/forms/submit-form-attributes.html:23
>  input.setAttribute('formAction', 'http://localhost');
> -shouldBe('input.formAction', '"http://localhost/"');
> +shouldBeEqualToString("input.formAction", "http://localhost/");
>  input.setAttribute('formAction', 'http://localhost/');

It seems the primary quote mark in this file is single quote.  Please use consistent quote marks.

[Vineet Chaudhary (vineetc)]

Created attachment 186714 [details]
updated_patch

(In reply to comment #2)
> (From update of attachment 186684 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186684&action=review
> 
> > LayoutTests/fast/forms/submit-form-attributes.html:23
> >  input.setAttribute('formAction', 'http://localhost');
> > -shouldBe('input.formAction', '"http://localhost/"');
> > +shouldBeEqualToString("input.formAction", "http://localhost/");
> >  input.setAttribute('formAction', 'http://localhost/');
> 
> It seems the primary quote mark in this file is single quote.  Please use consistent quote marks.

Updated test to use single quote as primary quote mark.
Thank you tkent for review comments.

[Kent Tamura]

Comment on attachment 186714 [details]
updated_patch

ok

[WebKit Review Bot]

Comment on attachment 186714 [details]
updated_patch

Clearing flags on attachment: 186714

Committed r141947: <http://trac.webkit.org/changeset/141947>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.