Bug 108966 - [chromium] Remove "config.h" header from WebUnitTests.cpp
Summary: [chromium] Remove "config.h" header from WebUnitTests.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
Depends on:
Reported: 2013-02-05 12:03 PST by Daniel Cheng
Modified: 2013-02-06 13:37 PST (History)
1 user (show)

See Also:

Patch (1.69 KB, patch)
2013-02-05 12:07 PST, Daniel Cheng
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2013-02-05 12:03:41 PST
WebUnitTests.cpp is an intentional layering violation and includes some headers from base/ in the Chromium code. "config.h" is largely unneeded (it was used for ASSERT, and attempting to run a null test suite isn't going to get very far anyway) and conflicted with base/logging.h, so it'd be nice to remove it rather than teach certain files not to #include base/logging.h.
Comment 1 Daniel Cheng 2013-02-05 12:07:12 PST
Created attachment 186671 [details]
Comment 2 Tony Chang 2013-02-06 13:24:25 PST
Comment on attachment 186671 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=186671&action=review

> Source/WebKit/chromium/tests/WebUnitTests.cpp:33
>  #include <base/test/test_suite.h>

Please add a FIXME about this include since it's a layering violation.
Comment 3 Daniel Cheng 2013-02-06 13:37:26 PST
Committed r142027: <http://trac.webkit.org/changeset/142027>