Bug 108961 – [GTK][AC] Implement opacity animation with clutter ac backend

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

In this bug, I plan to add opacity animation with clutter backend.

[ChangSeok Oh]

Created attachment 186675 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 186675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186675&action=review

Looks OK in general, just a few nits.

> Source/WebCore/ChangeLog:9
> +        Almost implementations of GraphicsLayerClutter are based on mac port's one.

This sentence seems to be missing a word. "Almost all"?

> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:32
>  
> +#include <wtf/text/CString.h>

No blank line.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:45
> +
> +#include <limits.h>

Ditto.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:53
> +// If we send a duration of 0 to CA, then it will use the default duration

Talking about CA here doesn't make much sense =)

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:678
> +    // CoreAnimation does not handle the steps() timing function. Fall back

Another CA-related comment here.

> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:398
> +        notImplemented();
> +    else if (m_animatedPropertyType == BackgroundColor)
> +        notImplemented();

Make these ASSERT_NOT_REACHED() for now? You should be refusing to create these kinds of animations, so they should really not be reached.

[ChangSeok Oh]

Created attachment 186859 [details]
Patch

[ChangSeok Oh]

Comment on attachment 186675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186675&action=review

Thanks! :D

>> Source/WebCore/ChangeLog:9
>> +        Almost implementations of GraphicsLayerClutter are based on mac port's one.
> 
> This sentence seems to be missing a word. "Almost all"?

Oops. Sorry.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:32
>> +#include <wtf/text/CString.h>
> 
> No blank line.

Done

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:45
>> +#include <limits.h>
> 
> Ditto.

yeap.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:53
>> +// If we send a duration of 0 to CA, then it will use the default duration
> 
> Talking about CA here doesn't make much sense =)

Updated the comment talking about clutterTimeline.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:678
>> +    // CoreAnimation does not handle the steps() timing function. Fall back
> 
> Another CA-related comment here.

I rewrote this comment.

>> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:398
>> +        notImplemented();
> 
> Make these ASSERT_NOT_REACHED() for now? You should be refusing to create these kinds of animations, so they should really not be reached.

Done

[WebKit Review Bot]

Comment on attachment 186859 [details]
Patch

Clearing flags on attachment: 186859

Committed r142094: <http://trac.webkit.org/changeset/142094>

[Sergio Villar Senin]

forgot to close the bug?