Bug 108948 – Add a performance test for arabic line breaking

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dominik Röttsches (drott)]

Adding an arabic line breaking perfomance text to exercise the complex font path.
Text source is the arabic version of One Thousand and One Nights
http://ar.wikisource.org/wiki/%D8%A3%D9%84%D9%81_%D9%84%D9%8A%D9%84%D8%A9_%D9%88%D9%84%D9%8A%D9%84%D8%A9/%D8%A7%D9%84%D8%AC%D8%B2%D8%A1_%D8%A7%D9%84%D8%A3%D9%88%D9%84
which according to all I could find out is in the public domain.

[Chris Dumez]

do you mean "text" or "test"?

[Dominik Röttsches (drott)]

Created attachment 186630 [details]
Patch

[Dominik Röttsches (drott)]

(In reply to comment #1)
> do you mean "text" or "test"?

Test, sry.

[Dominik Röttsches (drott)]

Created attachment 186631 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 186631 [details]
Patch

So this is going to include the creation of the rendering tree from scratch, is that what you intented?

[Dominik Röttsches (drott)]

(In reply to comment #5)
> (From update of attachment 186631 [details])
> So this is going to include the creation of the rendering tree from scratch, is that what you intented?

Yes, my intention was to get the width measurement of the complex font path measured. As far as I understand, creating the render tree initially does this in a similar way as a reflow.

[Ryosuke Niwa]

Comment on attachment 186631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186631&action=review

> PerformanceTests/ChangeLog:11
> +        * Layout/arabic-line-layout.html: Added.

Please skip this test by default.

[Ryosuke Niwa]

Also, please use CamelCase.

[Ryosuke Niwa]

(In reply to comment #8)
> Also, please use CamelCase.

for the file name.

[Dominik Röttsches (drott)]

Created attachment 186660 [details]
Patch, v2 - Skipping.

[WebKit Review Bot]

Comment on attachment 186660 [details]
Patch, v2 - Skipping.

Clearing flags on attachment: 186660

Committed r141906: <http://trac.webkit.org/changeset/141906>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.