Bug 108935 - [Qt] Compile WTF tests of TestWebKitAPI
: [Qt] Compile WTF tests of TestWebKitAPI
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Simon Hausmann
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-05 06:00 PST by Simon Hausmann
Modified: 2013-02-07 00:27 PST (History)
7 users (show)

See Also:


Attachments
Patch (11.75 KB, patch)
2013-02-05 06:02 PST, Simon Hausmann
kenneth: review+
webkit-ews: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2013-02-05 06:00:58 PST
[Qt] Compile WTF tests of TestWebKitAPI
Comment 1 Simon Hausmann 2013-02-05 06:02:34 PST
Created attachment 186611 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-05 06:08:37 PST
Comment on attachment 186611 [details]
Patch

Attachment 186611 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16377628
Comment 3 Kenneth Rohde Christiansen 2013-02-05 06:12:24 PST
Comment on attachment 186611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186611&action=review

> Tools/TestWebKitAPI/qt/InjectedBundleControllerQt.cpp:2
> + * Copyright (C) 2012 Igalia S.L.

IS that right?
Comment 4 WebKit Review Bot 2013-02-05 07:21:35 PST
Comment on attachment 186611 [details]
Patch

Attachment 186611 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16379615

New failing tests:
fast/frames/parser-append-subframe-count.html
Comment 5 Simon Hausmann 2013-02-05 08:18:14 PST
Comment on attachment 186611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186611&action=review

>> Tools/TestWebKitAPI/qt/InjectedBundleControllerQt.cpp:2
>> + * Copyright (C) 2012 Igalia S.L.
> 
> IS that right?

Yeah, I copied the Gtk "implementation"
Comment 6 Simon Hausmann 2013-02-07 00:27:20 PST
Committed r142070: <http://trac.webkit.org/changeset/142070>