Bug 108933 - Web Inspector: file selector list jumps as I type or move Up/Down
Summary: Web Inspector: file selector list jumps as I type or move Up/Down
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2013-02-05 05:27 PST by Pavel Feldman
Modified: 2013-02-06 02:13 PST (History)
8 users (show)

See Also:

Patch (6.66 KB, patch)
2013-02-05 05:35 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2013-02-06 01:35 PST, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-02-05 05:27:26 PST
Fix to follow.
Comment 1 Pavel Feldman 2013-02-05 05:35:54 PST
Created attachment 186608 [details]
Comment 2 Build Bot 2013-02-05 07:33:15 PST
Comment on attachment 186608 [details]

Attachment 186608 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16379608
Comment 3 Vsevolod Vlasov 2013-02-06 00:26:02 PST
Comment on attachment 186608 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=186608&action=review

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:288
> +        this._updateSelection(this._selectedIndexInFiltered, false);

Should we check this._selectedIndexInFiltered for null?

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:301
> +                event.consume();

Wouldn't it be better to do event.consume(true) instead?

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:302
> +                return;

These "return; break;" pairs look really weird. I would move _scheduleFilter call to default section of this switch instead.
Comment 4 Pavel Feldman 2013-02-06 01:35:53 PST
Created attachment 186788 [details]
Comment 5 Pavel Feldman 2013-02-06 02:13:32 PST
Committed r141979: <http://trac.webkit.org/changeset/141979>