Bug 108930 - Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
Summary: Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 04:11 PST by Eugene Klyuchnikov
Modified: 2013-03-01 07:17 PST (History)
11 users (show)

See Also:

Attachments
Patch (10.12 KB, patch)
2013-02-05 05:00 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Screenshot (51.41 KB, image/png)
2013-02-06 06:28 PST, Eugene Klyuchnikov 		no flags Details
Patch (11.45 KB, patch)
2013-02-11 07:00 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Screenshot: expand hoverable "frame" space. (44.38 KB, image/png)
2013-02-19 01:17 PST, Eugene Klyuchnikov 		no flags Details
Screenshot (51.41 KB, image/png)
2013-03-01 04:38 PST, Eugene Klyuchnikov 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-02-05 04:11:48 PST 
This feature will help developers to focus on events that caused CPU bar.
Comment 1 Eugene Klyuchnikov 2013-02-05 05:00:11 PST 
Created attachment 186603 [details]
Patch
Comment 2 Pavel Feldman 2013-02-06 04:11:01 PST 
A screenshot?
Comment 3 Eugene Klyuchnikov 2013-02-06 06:28:30 PST 
Created attachment 186841 [details]
Screenshot
Comment 4 Andrey Kosyakov 2013-02-07 05:44:34 PST 
Comment on attachment 186603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186603&action=review

The CPU bars would be on top of frame bars in frame mode. I'm a bit concerned how this will look when one attempts to hover over frames to get frame stats...

> Source/WebCore/inspector/front-end/Popover.js:74
> +        this._innerShow(view, view.element, anchor, preferredWidth, preferredHeight, null);

drop null

> Source/WebCore/inspector/front-end/Popover.js:160
> +        if ((roomAbove > roomBelow) || (arrowDirection === "bottom")) {

Please add an enum-style class for the direction.
Comment 5 Vsevolod Vlasov 2013-02-11 02:03:28 PST 
Comment on attachment 186603 [details]
Patch

r- per Andrey;s comment
Comment 6 Eugene Klyuchnikov 2013-02-11 07:00:38 PST 
Created attachment 187564 [details]
Patch
Comment 7 Eugene Klyuchnikov 2013-02-19 01:17:45 PST 
Created attachment 189018 [details]
Screenshot: expand hoverable "frame" space.

@caseq: How do you feel about making "CPU" smaller?
Comment 8 Eugene Klyuchnikov 2013-02-26 09:55:11 PST 
Comment on attachment 187564 [details]
Patch

"hover over frames" is addressed in another bug/patch.
PTAL.
Comment 9 Eugene Klyuchnikov 2013-03-01 04:38:21 PST 
Created attachment 190935 [details]
Screenshot
Comment 10 WebKit Review Bot 2013-03-01 07:17:30 PST 
Comment on attachment 187564 [details]
Patch

Clearing flags on attachment: 187564

Committed r144453: <http://trac.webkit.org/changeset/144453>
Comment 11 WebKit Review Bot 2013-03-01 07:17:34 PST 
All reviewed patches have been landed.  Closing bug.