Bug 108924 - INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fields.
Summary: INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 108795
  Show dependency tree / graph
 
Reported: 2013-02-05 01:57 PST by Kent Tamura
Modified: 2013-02-05 05:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2013-02-05 02:01 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing (6.97 KB, patch)
2013-02-05 05:08 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2013-02-05 01:57:38 PST 
INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fields.
Comment 1 Kent Tamura 2013-02-05 02:01:20 PST 
Created attachment 186577 [details]
Patch
Comment 2 Kentaro Hara 2013-02-05 04:02:45 PST 
Comment on attachment 186577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186577&action=review

> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html:15
> +dateInput.max = '2013-02-28';

How about changing this to dateInput.max = '2013-03-31', and test that the first focus() focuses on the month field and the second focus() focuses on the day field?
Comment 3 Kent Tamura 2013-02-05 05:04:30 PST 
Comment on attachment 186577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186577&action=review

>> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html:15
>> +dateInput.max = '2013-02-28';
> 
> How about changing this to dateInput.max = '2013-03-31', and test that the first focus() focuses on the month field and the second focus() focuses on the day field?

The second focus won't have different result. However it might be good to confirm non-different result in the test.
Comment 4 Kent Tamura 2013-02-05 05:08:45 PST 
Created attachment 186605 [details]
Patch for landing

test change
Comment 5 Kentaro Hara 2013-02-05 05:09:29 PST 
(In reply to comment #3)
> The second focus won't have different result. However it might be good to confirm non-different result in the test.

Makes sense to me. Thanks.
Comment 6 WebKit Review Bot 2013-02-05 05:55:51 PST 
Comment on attachment 186605 [details]
Patch for landing

Clearing flags on attachment: 186605

Committed r141889: <http://trac.webkit.org/changeset/141889>
Comment 7 WebKit Review Bot 2013-02-05 05:55:55 PST 
All reviewed patches have been landed.  Closing bug.