Bug 108920 – [Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate

[Simon Hausmann]

Created attachment 186567 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 186567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:327
> +    {
> +        WKPageFindClient findClient;
> +        memset(&findClient, 0, sizeof(WKPageFindClient));
> +        findClient.version = kWKPageFindClientCurrentVersion;
> +        findClient.clientInfo = this;
> +        findClient.didFindString = didFindString;
> +        findClient.didFailToFindString = didFailToFindString;
> +        WKPageSetPageFindClient(toAPI(webPageProxy.get()), &findClient);
> +    }

If the intent is to do so with most C API clients, it would be cleaner move all their initialization in a separate method.
We can also do this once we have more of them here.
r=me either way.

[Simon Hausmann]

This still needs a sign-off from a WK2 owner. Benjamin, can you help us with this? :)

[Benjamin Poulain]

Comment on attachment 186567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review

Okay with me, feel free to land.

Isn't that exposing a bit too much in case you want to make QQuickWebView publicly available from C++?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:2082
> +    didFindString(page, string, 0, clientInfo);

Maybe prefix by QQuickWebViewPrivate:: for clarity?

[Simon Hausmann]

(In reply to comment #4)
> (From update of attachment 186567 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review
> 
> Okay with me, feel free to land.

Thank you!
 
> Isn't that exposing a bit too much in case you want to make QQuickWebView 
publicly available from C++?

It is becoming less and less likely that we're going to make the QML implementation a public C++ API :)
 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:2082
> > +    didFindString(page, string, 0, clientInfo);
> 
> Maybe prefix by QQuickWebViewPrivate:: for clarity?

Good idea.

[Simon Hausmann]

Committed r142073: <http://trac.webkit.org/changeset/142073>