10892 – Fix the member variables in HTMLTableElement to be RefPtrs and to update properly across dynamic changes

RESOLVED CONFIGURATION CHANGED 10892

Fix the member variables in HTMLTableElement to be RefPtrs and to update properly across dynamic changes

https://bugs.webkit.org/show_bug.cgi?id=10892

Summary Fix the member variables in HTMLTableElement to be RefPtrs and to update prop...

Dave Hyatt

Reported 2006-09-16 16:44:12 PDT

The head, body, foot and caption members of HTMLTableElement should be RefPtrs. They also need to update properly in response to dynamic DOM changes (they are not doing that correctly at all right now).

Attachments
Add attachment proposed patch, testcase, etc.

Ahmad Saleem

Comment 1 2022-07-30 08:04:02 PDT

Table Head https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L81 Table Foot https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L108 Table Caption https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L68 I think only body is not yet RefPtrs but I might be wrong: https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L157 Just wanted to update and also please update accordingly whether it can be "RESOLVED LATER" or it is something already done. Thanks!

Ryosuke Niwa

Comment 2 2022-07-30 13:21:15 PDT

We don't store these nodes as member variables anymore,

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution CONFIGURATION CHANGED

Priority P2

Severity Normal

Classification Unclassified

Version 420+

Hardware Mac

OS OS X 10.4

Product WebKit

Component Tables

Assignee

Nobody

Reported

2006-09-16 16:44 PDT

Modified

2022-07-30 13:21 PDT History

CC List

5 users Show

URL

Keywords

Depends on

Blocks