Now we've removed all call sites.
Created attachment 186566 [details] Patch
Comment on attachment 186566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186566&action=review > Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h:45 > class V8CustomXPathNSResolver : public XPathNSResolver { BTW, the implementation of V8CustomXPathNSResolver looks weird. The class exists just for keeping m_resolver. Alternately, we might want to store m_resolver to a ScriptState and pass the ScriptState around WebCore and JSC/V8 bindings. Then we can remove V8CustomXPathNSResolver and JSCustomXPathNSResolver.
Comment on attachment 186566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186566&action=review >> Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h:45 >> class V8CustomXPathNSResolver : public XPathNSResolver { > > BTW, the implementation of V8CustomXPathNSResolver looks weird. The class exists just for keeping m_resolver. Alternately, we might want to store m_resolver to a ScriptState and pass the ScriptState around WebCore and JSC/V8 bindings. Then we can remove V8CustomXPathNSResolver and JSCustomXPathNSResolver. Yes, I suspect that we have more modern tools for handling this case these days.
Comment on attachment 186566 [details] Patch Rejecting attachment 186566 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ue>&, const WTF::String&, v8::Handle<v8::Value>&)': ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:143: error: 'deprecatedV8String' was not declared in this scope ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp: In function 'bool WebCore::set(v8::Handle<v8::Value>&, const WTF::String&, const v8::Handle<v8::Value>&)': ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:153: error: 'deprecatedV8String' was not declared in this scope ninja: build stopped: subcommand failed. Full output: http://queues.webkit.org/results/16370939
Comment on attachment 186566 [details] Patch Clearing flags on attachment: 186566 Committed r141948: <http://trac.webkit.org/changeset/141948>
All reviewed patches have been landed. Closing bug.