Bug 108914 - INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus
Summary: INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 108795
  Show dependency tree / graph
 
Reported: 2013-02-04 23:43 PST by Kent Tamura
Modified: 2013-02-05 05:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.66 KB, patch)
2013-02-05 01:12 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (8.63 KB, patch)
2013-02-05 01:29 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing (8.53 KB, patch)
2013-02-05 04:43 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2013-02-04 23:43:46 PST 
INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus

Steps to reproduce this bug:
1. Open data:text/html,<input type=date>
2. Focus on the second or the third sub-field of the date input
3. A script calls dateInput.focus().

Expected:
  Nothing happens because the date input already has focus

Actual:
  The first sub-field is focused.
Comment 1 Kent Tamura 2013-02-05 01:12:39 PST 
Created attachment 186571 [details]
Patch
Comment 2 Build Bot 2013-02-05 01:20:49 PST 
Comment on attachment 186571 [details]
Patch

Attachment 186571 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16365710
Comment 3 Kent Tamura 2013-02-05 01:29:42 PST 
Created attachment 186574 [details]
Patch 2
Comment 4 Kentaro Hara 2013-02-05 03:55:47 PST 
Comment on attachment 186574 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=186574&action=review

Looks OK

> Source/WebCore/ChangeLog:8
> +        If timeInptu.focus() is called when a sub-field of the time input

Typo: timeInput

> Source/WebCore/ChangeLog:9
> +        already has focus, we should not focus on the first sub-filed of the

Typo: sub-field
Comment 5 Kent Tamura 2013-02-05 04:43:06 PST 
Created attachment 186597 [details]
Patch for landing

typo
Comment 6 WebKit Review Bot 2013-02-05 05:05:14 PST 
Comment on attachment 186597 [details]
Patch for landing

Clearing flags on attachment: 186597

Committed r141887: <http://trac.webkit.org/changeset/141887>
Comment 7 WebKit Review Bot 2013-02-05 05:05:19 PST 
All reviewed patches have been landed.  Closing bug.