Bug 108910 - touch-event.html should check touchstartFiredInShadowDOM is true.
Summary: touch-event.html should check touchstartFiredInShadowDOM is true.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 107796
  Show dependency tree / graph
 
Reported: 2013-02-04 23:06 PST by Shinya Kawanaka
Modified: 2013-02-05 01:07 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2013-02-04 23:10 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch for landing (2.06 KB, patch)
2013-02-05 00:40 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2013-02-04 23:06:27 PST 
Maybe I forgot to check touchstartFiredInShadowDOM in touch-event.html.
We definitely check it.
Comment 1 Shinya Kawanaka 2013-02-04 23:10:26 PST 
Created attachment 186554 [details]
Patch
Comment 2 Hayato Ito 2013-02-05 00:00:46 PST 
Unofficial rs=me on this.

Looks okay to me since this fixes a trivial mistake on the layout test committed previously.

Note that there are still cases where touch events are not fired on shadow tree. See bug 108908.
Comment 3 Hajime Morrita 2013-02-05 00:16:08 PST 
Comment on attachment 186554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review

> LayoutTests/ChangeLog:8
> +        We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM.

This looks like a followup patch. Could you refer the original revision?
Comment 4 Shinya Kawanaka 2013-02-05 00:40:10 PST 
Created attachment 186564 [details]
Patch for landing
Comment 5 Shinya Kawanaka 2013-02-05 00:40:33 PST 
(In reply to comment #3)
> (From update of attachment 186554 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM.
> 
> This looks like a followup patch. Could you refer the original revision?

Sure.
Comment 6 WebKit Review Bot 2013-02-05 01:07:08 PST 
Comment on attachment 186564 [details]
Patch for landing

Clearing flags on attachment: 186564

Committed r141869: <http://trac.webkit.org/changeset/141869>
Comment 7 WebKit Review Bot 2013-02-05 01:07:13 PST 
All reviewed patches have been landed.  Closing bug.