Bug 108891 - EWS bots don't remove untracked files after processing a patch
Summary: EWS bots don't remove untracked files after processing a patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-04 19:42 PST by Alan Cutter
Modified: 2013-02-05 00:02 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2013-02-04 22:55 PST, Alan Cutter
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Cutter 2013-02-04 19:42:47 PST
gce-cr-linux-06 and gce-cr-linux-08 were crashing on tests due to the presence of a third_party/WebKit/LayoutTests directory path in the repository. These files and folders were not being cleaned out of the repository automatically and causing the tests to crash.
Comment 1 Alan Cutter 2013-02-04 22:55:07 PST
Created attachment 186552 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-04 23:08:39 PST
This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :)

That's OK.  But we had intentionally avoided this before.
Comment 3 Alan Cutter 2013-02-04 23:16:45 PST
(In reply to comment #2)
> This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :)
> 
> That's OK.  But we had intentionally avoided this before.

Those files appear to be .gitignored, git clean doesn't remove ignored files unless -x is given as well. Good consideration though!
Comment 4 Adam Barth 2013-02-04 23:46:55 PST
Comment on attachment 186552 [details]
Patch

Ok.  If this doesn't blow away the Chromium Turducken, then this sounds like a good change.
Comment 5 WebKit Review Bot 2013-02-05 00:01:58 PST
Comment on attachment 186552 [details]
Patch

Clearing flags on attachment: 186552

Committed r141863: <http://trac.webkit.org/changeset/141863>
Comment 6 WebKit Review Bot 2013-02-05 00:02:02 PST
All reviewed patches have been landed.  Closing bug.