WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108891
EWS bots don't remove untracked files after processing a patch
https://bugs.webkit.org/show_bug.cgi?id=108891
Summary
EWS bots don't remove untracked files after processing a patch
Alan Cutter
Reported
2013-02-04 19:42:47 PST
gce-cr-linux-06 and gce-cr-linux-08 were crashing on tests due to the presence of a third_party/WebKit/LayoutTests directory path in the repository. These files and folders were not being cleaned out of the repository automatically and causing the tests to crash.
Attachments
Patch
(1.46 KB, patch)
2013-02-04 22:55 PST
,
Alan Cutter
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alan Cutter
Comment 1
2013-02-04 22:55:07 PST
Created
attachment 186552
[details]
Patch
Eric Seidel (no email)
Comment 2
2013-02-04 23:08:39 PST
This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :) That's OK. But we had intentionally avoided this before.
Alan Cutter
Comment 3
2013-02-04 23:16:45 PST
(In reply to
comment #2
)
> This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :) > > That's OK. But we had intentionally avoided this before.
Those files appear to be .gitignored, git clean doesn't remove ignored files unless -x is given as well. Good consideration though!
Adam Barth
Comment 4
2013-02-04 23:46:55 PST
Comment on
attachment 186552
[details]
Patch Ok. If this doesn't blow away the Chromium Turducken, then this sounds like a good change.
WebKit Review Bot
Comment 5
2013-02-05 00:01:58 PST
Comment on
attachment 186552
[details]
Patch Clearing flags on attachment: 186552 Committed
r141863
: <
http://trac.webkit.org/changeset/141863
>
WebKit Review Bot
Comment 6
2013-02-05 00:02:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug